From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74412: 31.0.50; Treesit-outline conflict with outli in Emacs 31 Date: Wed, 20 Nov 2024 20:53:07 +0200 Message-ID: <86h681spnw.fsf@gnu.org> References: <9e9fcc46-e6ca-42e6-bb0e-6770ae65f150@gmail.com> <8316FFB6-1373-4EC5-9EFB-5B05A1DE0F72@getmailspring.com> <87serlzuvi.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34345"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74412@debbugs.gnu.org, liaotx2@gmail.com, daanturo@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 20 19:54:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDpq8-0008mb-RT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Nov 2024 19:54:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDpq0-0002zX-Td; Wed, 20 Nov 2024 13:54:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDppy-0002z3-6R for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 13:54:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDppx-0007c2-UQ for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 13:54:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=/MFOS8kiRGdh/vPEPoGJ1TerpkDpwiXU9YPcOWl1/bE=; b=YHsv1cRtK1NMMXMWcLVpIsMcrONX8ZFatOWznxi4UNO/WV/nrW1KFcCo/LJqi7cOfq5xW4imTUFEjuCSwmrTkynZkOg9cjDEFEqmbhPXqOuu9NI/x/CukrNtx5uMdMsOMrmP4vkoKiSDVwGvKocGIgjJykSlF6mWZ80Akmfc5Z731edTfcO/uFHkmBNsutPsEPklKJeFiDOvjzKaHxxpnSa+N7NpcmRy7SDEWiZHqmrj/7cqz9o6MoDrYp0aUkHqAbDzmbPBNHwUj13BufVkXKWYAvyMnWH0CDRwV6oh/5FYhJTglt43yID7701m4peXENackjNIgC/UzD5l6S0aVg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDppx-0002cV-P6 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 13:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2024 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74412 X-GNU-PR-Package: emacs Original-Received: via spool by 74412-submit@debbugs.gnu.org id=B74412.173212880010011 (code B ref 74412); Wed, 20 Nov 2024 18:54:01 +0000 Original-Received: (at 74412) by debbugs.gnu.org; 20 Nov 2024 18:53:20 +0000 Original-Received: from localhost ([127.0.0.1]:47754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDppI-0002bO-Di for submit@debbugs.gnu.org; Wed, 20 Nov 2024 13:53:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDppF-0002b3-Ml for 74412@debbugs.gnu.org; Wed, 20 Nov 2024 13:53:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDpp9-0007Q5-Sw; Wed, 20 Nov 2024 13:53:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/MFOS8kiRGdh/vPEPoGJ1TerpkDpwiXU9YPcOWl1/bE=; b=jTvmFYrpT6PV PDoDejJLl0V2xrV2tmysl/DkN46cl1PKuidqog1EfprIXiRhiUu8UXbXHf15rV8ZW3w/cAxHH07sW 8y2UjCYTbdayaVE/neaFXpIebvxUJ9Xhy5j+Tj6Gj1/blJy+IcffGq2q2Zd88q2twrKEGzLiZiI9s 4Kuup+e0lslUyYo+mnA7otzDjifVGgaG3n9rjuWgjNzBVYURE4zkmSx5nK7VfKYNH1lWMO0avl7rm 0U0EqSC1BHd2y6khHo1BHaQgpl016FGsgvB5LdCsOxqFdzoC0ybvdiGpqCirBS0wNm7OueIMjw64F 50I0dFmN+ovGCJHXcuOaLA==; In-Reply-To: <87serlzuvi.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 20 Nov 2024 19:18:41 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295692 Archived-At: > Cc: "74412@debbugs.gnu.org" <74412@debbugs.gnu.org>, > "liaotx2@gmail.com" > From: Juri Linkov > Date: Wed, 20 Nov 2024 19:18:41 +0200 > > > Personally I also find treesit's decision to set outline variables > > somewhat intrusive. I have to advice `treesit-major-mode-setup` to > > disable that. If only there is an easier way to do it like the > > attached patch. > > > > +(defcustom treesit-enable-outline-settings t > > + "Non-nil means Tree sitter-based outline settings are enabled." > > + :type 'boolean > > + :version "31.1") > > Should such an option be more general and allow > disabling some other features too? I don't see a need for an option at all. All tree-sitter based modes use these search functions, so treesit.el simply acts on their behalf here. It makes no sense to let users control how a major mode customizes outline-minor-mode, because the major mode is supposed to know how to adapt outlines with its main syntax, and what a heading means in the context of that mode.