From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#11017: 24.0.94; emacs-lock--kill-emacs-query-functions should ding Date: Sat, 14 Apr 2012 02:36:38 +0200 Message-ID: <86fwc740a1.fsf@web.de> References: <86mx7i79lb.fsf@web.de> <86obrxuz7p.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1334363509 32680 80.91.229.3 (14 Apr 2012 00:31:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 14 Apr 2012 00:31:49 +0000 (UTC) Cc: Juanma Barranquero To: 11017@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 14 02:31:48 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SIqu3-0007wD-SY for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2012 02:31:48 +0200 Original-Received: from localhost ([::1]:41262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIqu2-00063S-Ut for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Apr 2012 20:31:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIqtz-000635-NY for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2012 20:31:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SIqtx-0007IG-OK for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2012 20:31:43 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIqtx-0007I5-Kq for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2012 20:31:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SIqvG-0001Ef-6X for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2012 20:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Apr 2012 00:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11017 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13343635274679 (code B ref -1); Sat, 14 Apr 2012 00:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Apr 2012 00:32:07 +0000 Original-Received: from localhost ([127.0.0.1]:57824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIquL-0001DP-RW for submit@debbugs.gnu.org; Fri, 13 Apr 2012 20:32:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58004) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIquJ-0001DH-LS for submit@debbugs.gnu.org; Fri, 13 Apr 2012 20:32:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SIqsy-0006rG-Jb for submit@debbugs.gnu.org; Fri, 13 Apr 2012 20:30:42 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:36940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIqsy-0006r4-GI for submit@debbugs.gnu.org; Fri, 13 Apr 2012 20:30:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIqsw-000606-SI for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2012 20:30:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SIqsu-0006pW-Tz for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2012 20:30:38 -0400 Original-Received: from fmmailgate04.web.de ([217.72.192.242]:53848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIqsu-0006ot-Jg for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2012 20:30:36 -0400 Original-Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate04.web.de (Postfix) with ESMTP id 5AB8975D8B6A for ; Sat, 14 Apr 2012 02:30:14 +0200 (CEST) Original-Received: from dragon.dragon ([88.67.107.46]) by smtp.web.de (mrweb002) with ESMTPA (Nemesis) id 0MGARb-1SY1ZK1vHz-00FAMj; Sat, 14 Apr 2012 02:30:14 +0200 In-Reply-To: (Juanma Barranquero's message of "Tue, 10 Apr 2012 16:33:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-Provags-ID: V02:K0:rIlfe09a4A1NPbfNylRdItN4bBMDrIPm5QnNk9mfEvU pPMaQ7MXom4Un8FAFpkyeu4koxiPiSYwFW3MHt+e5HcgwKReL6 MJO9M97/2eNSKIB7OSJiFdDYt+l1Cr951fcanTX4pdeqjBM3ys Y7KoAYN5EpAhBnndCMtdaZiPtLxiJjNXP/5tfp+T83q5FXeWYt LswWTmuUmKSbu2hgQG/RdasLhktkYwhHmtFdKPQPVs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59022 Archived-At: Hello Juanma, > Michael, this patch adds the hook described above. Could you please > test it and see whether it works for you use case? Yes, this looks really good. With (add-hook 'emacs-lock-locked-buffer-hook (lambda (buffer) (ding) (pop-to-buffer buffer))) I get all I want. So, I'm happy with your patch. However, should `emacs-lock-locked-buffer-hook' not better be named `...-functions' or so? Because, from the manual: | By convention, abnormal hook names end in `-functions' or `-hooks'. | If the variable's name ends in `-function', then its value is just a | single function, not a list of functions. > As for the note option, I'm thinking about unobtrusive ways to add it. Mmh, the prefix arg of `emacs-lock-mode' is already used for the locking mode. So we'll probably need a separate command that reads the note text and saves it to a buffer local variable, and maybe a user option that controls if this command is run automatically by emacs-lock-mode. Then I would just change the standard messages: (message "Emacs cannot exit because buffer %S is locked" (buffer-name locked)) (message "Buffer %S is locked and cannot be killed" (buffer-name)) to include the note - Just a proposal. Anyway, if you have a patch, please send it to the bug's address again. Regards, Michael.