From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Wed, 13 Oct 2021 06:41:20 -0700 Message-ID: <86fst5m48v.fsf@runbox.com> References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> <83fste2u4i.fsf@gnu.org> <87ily94662.fsf@gnus.org> <83fstd1bth.fsf@gnu.org> <87czogslm4.fsf@gnus.org> <86ily2mjtq.fsf@runbox.com> <87r1cp89o4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3977"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 28.0.50 Cc: 51037@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 13 15:42:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maeWK-0000l8-2d for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Oct 2021 15:42:12 +0200 Original-Received: from localhost ([::1]:47064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maeWI-0006rX-D8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Oct 2021 09:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maeWA-0006mx-Cp for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2021 09:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maeWA-0005Nr-3V for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2021 09:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maeWA-0001Lc-1d for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2021 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Oct 2021 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.16341324915137 (code B ref 51037); Wed, 13 Oct 2021 13:42:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 13 Oct 2021 13:41:31 +0000 Original-Received: from localhost ([127.0.0.1]:59077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maeVf-0001Kn-Bo for submit@debbugs.gnu.org; Wed, 13 Oct 2021 09:41:31 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:39678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maeVb-0001Kd-Vo for 51037@debbugs.gnu.org; Wed, 13 Oct 2021 09:41:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject :Cc:To:From:References; bh=jgvdPW3nE2L+L8U+opV9LKuTsBtxKpM6DhNyoszoNfM=; b=XT LXWN2AlDI+q5l/m91eVvUuWEqz757LFxW6r36vZZ9YUOvg7gv09ckyqjSzywtiZZFHFG/JACmEFyv 9MiOCIwUPb2VVBoCJT/4HC9fcQftXxCr40eNFITMl5fC5xndiTAbvg/24UfJa34iDS0eaJzg+nuRa wwNXzWizNXfEc+1V2vKHGde4OQVM15ra1NMZh68iyyUJdjuiwsTrCU4smo1fOMhutbrgyqYYO+D3Y mx4M2ORP3xQx/MhjNmYAeNagAKSkFQ3hjzQ8HE+CsohMkNVpNQUm/BWEsh6L8XjSesaWggiGGxVtR HCYWRTY3oOtTliHtufAyQSjymugkUm8A==; Original-Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1maeVZ-0006xy-V0; Wed, 13 Oct 2021 15:41:26 +0200 Original-Received: by submission02.runbox with esmtpsa [Authenticated ID (942723)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1maeVY-0000Ct-I9; Wed, 13 Oct 2021 15:41:24 +0200 In-reply-to: <87r1cp89o4.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217126 Archived-At: Hey Lars, >> Sorry to chime-in late, but my patch does _not_ affect the >> printing of backtraces, just results. That said, I do agree >> with >> Eli about the truncated backtraces often being useless; what do >> you think of another variable controlling >> that... `ert-batch-full-backtraces` or something? > > I'm not sure I quite follow you here -- the original patch would > make > the backtraces printed by ert more complete, wouldn't they? Only when comparing _results_. Say I have test code like: (let ((a () (b ()))) ... (should (equal a b)) My changes would case the error message from the failed `should` invocation to print `a` & `b` more fully (i.e. with fewwer ellipses). The backtrace logic is separate, and un-touched by my patch as submitted (tho of course I can change that). -- Michael