From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Sun, 02 Jan 2022 21:27:37 +0200 Organization: LINKOV.NET Message-ID: <86fsq63pli.fsf@mail.linkov.net> References: <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <723c8965-31be-b636-beee-478fb77423ec@gmail.com> <86ee6egs8b.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5018"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 02 20:30:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n46Z0-00017t-H3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jan 2022 20:30:42 +0100 Original-Received: from localhost ([::1]:58968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n46Yz-0005FU-8b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jan 2022 14:30:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n46YM-0005Do-P0 for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 14:30:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n46YM-0003Gi-FX for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 14:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n46YM-0000nm-BF for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 14:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jan 2022 19:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16411517442986 (code B ref 52293); Sun, 02 Jan 2022 19:30:02 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 2 Jan 2022 19:29:04 +0000 Original-Received: from localhost ([127.0.0.1]:33746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n46XQ-0000m4-75 for submit@debbugs.gnu.org; Sun, 02 Jan 2022 14:29:04 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:38279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n46XO-0000lW-A6 for 52293@debbugs.gnu.org; Sun, 02 Jan 2022 14:29:03 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 167921BF203; Sun, 2 Jan 2022 19:28:54 +0000 (UTC) In-Reply-To: (Jim Porter's message of "Fri, 31 Dec 2021 23:13:21 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223562 Archived-At: > I've attached an updated patch that lets context-menu-functions add items > to the beginning of the keymap as they currently do, while still removing > consecutive separators correctly. Since this logic is a bit tricky, it > could probably use an automated test or two, but before I write some, > I wanted to check that the strategy I'm using seems reasonable. It's > probably easiest to explain the logic by just pointing to the patch; > I added several comments describing the behavior so that reviewers (and > future readers) should be able to make sense of it. Thanks, I suppose it's for master, not for the release branch?