From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52349: 29.0.50; vc-git and diff-mode: stage hunks Date: Sat, 27 Aug 2022 22:56:30 +0300 Organization: LINKOV.NET Message-ID: <86fshhmpe9.fsf@mail.linkov.net> References: <268cee0d-465d-b862-d1d6-f5da4d69e737@inventati.org> <9106387a-98cf-396f-bf45-ccb04581787b@yandex.ru> <864k7kfd56.fsf@mail.linkov.net> <86fsr3uen2.fsf@mail.linkov.net> <95d2d999-49ad-13c4-9f25-0935650a1e42@yandex.ru> <8635ktjfll.fsf@mail.linkov.net> <36b963e4-5af7-dd9e-af92-4404541b9f4d@yandex.ru> <86v8xjx45h.fsf@mail.linkov.net> <861qt9h1hh.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30076"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52349@debbugs.gnu.org, Dmitry Gutov To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 27 22:13:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oS2BN-0007g8-6g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Aug 2022 22:13:29 +0200 Original-Received: from localhost ([::1]:46566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oS2BM-0007I8-14 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Aug 2022 16:13:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oS2Aw-0007HP-UP for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 16:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oS2Aw-0004Ir-Do for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 16:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oS2Av-0003xO-R2 for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 16:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2022 20:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52349 X-GNU-PR-Package: emacs Original-Received: via spool by 52349-submit@debbugs.gnu.org id=B52349.166163117015181 (code B ref 52349); Sat, 27 Aug 2022 20:13:01 +0000 Original-Received: (at 52349) by debbugs.gnu.org; 27 Aug 2022 20:12:50 +0000 Original-Received: from localhost ([127.0.0.1]:57160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oS2Ak-0003wn-22 for submit@debbugs.gnu.org; Sat, 27 Aug 2022 16:12:50 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:47201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oS2Ag-0003wW-Kw for 52349@debbugs.gnu.org; Sat, 27 Aug 2022 16:12:49 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4924A200005; Sat, 27 Aug 2022 20:12:38 +0000 (UTC) In-Reply-To: (Filipp Gunbin's message of "Fri, 26 Aug 2022 20:11:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240964 Archived-At: > A minor comment: > >> +(defun vc-diff-patch () >> + (let ((buffer "*vc-diff*") >> + (patch-string vc-patch-string)) >> + (vc-setup-buffer buffer) >> + (set-buffer buffer) > > vc-setup-buffer already did set-buffer? Thanks for noticing, will be fixed in the next version. This is because vc-diff-patch tries to duplicate code from vc-diff-internal since the same function can't be reused for vc-diff-patch.