From: Juri Linkov <juri@linkov.net>
To: Jens Lechtenboerger <lechten@wi.uni-muenster.de>
Cc: 58605@debbugs.gnu.org, Filipp Gunbin <fgunbin@fastmail.fm>
Subject: bug#58605: 29.0.50; Commit 2a2f5530fa2 breaks ldap-search-internal
Date: Thu, 20 Oct 2022 11:12:04 +0300 [thread overview]
Message-ID: <86fsfidgyr.fsf@mail.linkov.net> (raw)
In-Reply-To: <87wn8xr7i6.fsf@wi.uni-muenster.de> (Jens Lechtenboerger's message of "Tue, 18 Oct 2022 08:05:53 +0200")
> commit 2a2f5530fa230e2b994be5683e63763833bb6a0a breaks
> ldap-search-internal for searches with empty results.
I confirm that ldap search is broken. When the output contains for example:
dn: cn=admin,dc=example,dc=com
then it raises the error:
insert-file-contents: Opening input file: No such file or directory, ~/cn=admin,dc=example,dc=com
> The added “?” should be removed there again:
>
> @@ -699,7 +699,7 @@ ldap-search-internal
> (forward-line 1)
> (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\
> \\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\
> -\\(<[\t ]*file://\\)\\(.*\\)$")
> +\\(<[\t ]*file://\\)?\\(.*\\)$")
> (setq name (match-string 1)
> value (match-string 4))
> ;; Need to handle file:///D:/... as generated by OpenLDAP
Removing “?” doesn't fix the problem because then nil is returned
even in case when there are results.
I guess this whole block
(with-current-buffer bufval
(erase-buffer)
(set-buffer-multibyte nil)
(insert-file-contents-literally value)
(delete-file value)
(setq value (buffer-string)))
should be executed only on a condition that checks that value contains "file://".
next prev parent reply other threads:[~2022-10-20 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 6:05 bug#58605: 29.0.50; Commit 2a2f5530fa2 breaks ldap-search-internal Jens Lechtenboerger
2022-10-18 14:17 ` Eli Zaretskii
2022-10-20 8:12 ` Juri Linkov [this message]
2022-10-20 17:58 ` Filipp Gunbin
2022-10-21 6:25 ` Jens Lechtenboerger
2022-10-21 15:16 ` Filipp Gunbin
2022-10-22 9:43 ` Jens Lechtenboerger
2022-10-24 16:06 ` Filipp Gunbin
2022-10-25 5:55 ` Jens Lechtenboerger
2022-10-25 13:12 ` Filipp Gunbin
2022-10-25 13:42 ` Jens Lechtenboerger
2022-10-25 15:07 ` Filipp Gunbin
2022-10-26 6:07 ` Jens Lechtenboerger
2022-10-26 13:20 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fsfidgyr.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=58605@debbugs.gnu.org \
--cc=fgunbin@fastmail.fm \
--cc=lechten@wi.uni-muenster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).