From: Arash Esbati <arash@gnu.org>
To: Danny Freeman <danny@dfreeman.email>
Cc: eliz@gnu.org, arstoffel@gmail.com, 59338@debbugs.gnu.org
Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows
Date: Fri, 18 Nov 2022 21:01:54 +0100 [thread overview]
Message-ID: <86fsegowul.fsf@gnu.org> (raw)
In-Reply-To: <87bkp4wazv.fsf@dfreeman.email> (Danny Freeman's message of "Fri, 18 Nov 2022 09:55:47 -0500")
Danny Freeman <danny@dfreeman.email> writes:
> I can confirm it works on linux, but I don't have a windows machine.
> Someone else would need to verify it there.
Many thanks for working on this. I tried your patch on my Windows box
and this is what I get:
(require 'eglot)
(insert "\n" (format "%s" (eglot--path-to-uri
"d:/digestif-test/tikz-test.tex")))
=> file:///d%3A/digestif-test/tikz-test.tex
(insert "\n" (format "%s" (eglot--path-to-uri
"d:/digestif-test/tikz test.tex")))
=> file:///d%3A/digestif-test/tikz%20test.tex
As Eli already mentioned, %-escaping the colon seems to be wrong (I
couldn't find a definitive source for this, though), but it seems a
deliberate decision in eglot.el's `eglot--uri-path-allowed-chars', which
also references this GitHub issue[1]. My original problem is solved and
digestif-LSP works on Windows again. So for now, I suggest to apply
your patch and close this report.
Best, Arash
Footnotes:
[1] https://github.com/joaotavora/eglot/pull/639
next prev parent reply other threads:[~2022-11-18 20:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 16:51 bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Arash Esbati
2022-11-17 17:06 ` Eli Zaretskii
2022-11-17 17:18 ` Augusto Stoffel
2022-11-17 22:27 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-17 23:12 ` Augusto Stoffel
2022-11-18 7:14 ` Eli Zaretskii
2022-11-18 13:39 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 14:35 ` Eli Zaretskii
2022-11-18 14:55 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 20:01 ` Arash Esbati [this message]
2022-11-18 7:12 ` Eli Zaretskii
2022-11-23 12:51 ` João Távora
2022-11-24 13:42 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-24 15:27 ` João Távora
2022-11-17 22:33 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fsegowul.fsf@gnu.org \
--to=arash@gnu.org \
--cc=59338@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=danny@dfreeman.email \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).