unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* comp-tests-ret-type-spec-71 fails on 32-bit powerpc
@ 2023-09-14 12:28 John Paul Adrian Glaubitz
  2023-09-14 13:02 ` bug#65978: " Eli Zaretskii
  2024-03-07 18:42 ` Andrea Corallo
  0 siblings, 2 replies; 9+ messages in thread
From: John Paul Adrian Glaubitz @ 2023-09-14 12:28 UTC (permalink / raw)
  To: bug-gnu-emacs; +Cc: debian-powerpc

Hello!

The test comp-tests-ret-type-spec-71 reproducibly fails on 32-bit powerpc:

Test comp-tests-ret-type-spec-71 backtrace:
  signal(ert-test-failed (((should (equal (cl-third (subr-type (symbol
  ert-fail(((should (equal (cl-third (subr-type (symbol-function f-nam
  comp-tests-check-ret-type-spec((defun comp-tests-ret-type-spec-f (x)
  #f(compiled-function () #<bytecode -0x221c87d>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name comp-tests-ret-type-spec-71 :document
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  command-line-1(("-L" ":/<<PKGBUILDDIR>>/debian/build
  command-line()
  normal-top-level()
Test comp-tests-ret-type-spec-71 condition:
    (ert-test-failed
     ((should
       (equal
	(cl-third ...)
	ret-type))
      :form
      (equal
       (or
	(member 0.0 -0.0)
	(integer 0 0))
       (or
	(member -0.0 0.0)
	(integer 0 0)))
      :value nil :explanation
      (list-elt 1
		(list-elt 1
			  (different-atoms 0.0 -0.0)))))
   FAILED  145/166  comp-tests-ret-type-spec-71 (0.399696 sec)

The full buildlog can be obtained in [1].

Thanks,
Adrian

> [1] https://buildd.debian.org/status/fetch.php?pkg=emacs&arch=powerpc&ver=1%3A28.2%2B1-16&stamp=1690634247&raw=0

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#65978: comp-tests-ret-type-spec-71 fails on 32-bit powerpc
  2023-09-14 12:28 comp-tests-ret-type-spec-71 fails on 32-bit powerpc John Paul Adrian Glaubitz
@ 2023-09-14 13:02 ` Eli Zaretskii
  2023-09-14 14:44   ` Andrea Corallo
  2024-03-07 18:42 ` Andrea Corallo
  1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2023-09-14 13:02 UTC (permalink / raw)
  To: John Paul Adrian Glaubitz, Andreas Schwab; +Cc: debian-powerpc, 65978

> Cc: debian-powerpc <debian-powerpc@lists.debian.org>
> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Date: Thu, 14 Sep 2023 14:28:24 +0200
> 
> Hello!
> 
> The test comp-tests-ret-type-spec-71 reproducibly fails on 32-bit powerpc:
> 
> Test comp-tests-ret-type-spec-71 backtrace:
>   signal(ert-test-failed (((should (equal (cl-third (subr-type (symbol
>   ert-fail(((should (equal (cl-third (subr-type (symbol-function f-nam
>   comp-tests-check-ret-type-spec((defun comp-tests-ret-type-spec-f (x)
>   #f(compiled-function () #<bytecode -0x221c87d>)()
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name comp-tests-ret-type-spec-71 :document
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
>   ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
>   ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
>   command-line-1(("-L" ":/<<PKGBUILDDIR>>/debian/build
>   command-line()
>   normal-top-level()
> Test comp-tests-ret-type-spec-71 condition:
>     (ert-test-failed
>      ((should
>        (equal
> 	(cl-third ...)
> 	ret-type))
>       :form
>       (equal
>        (or
> 	(member 0.0 -0.0)
> 	(integer 0 0))
>        (or
> 	(member -0.0 0.0)
> 	(integer 0 0)))
>       :value nil :explanation
>       (list-elt 1
> 		(list-elt 1
> 			  (different-atoms 0.0 -0.0)))))
>    FAILED  145/166  comp-tests-ret-type-spec-71 (0.399696 sec)

Something about the sign of zero, I guess?  Adding Andreas, in the
hope that he will have some suggestions.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#65978: comp-tests-ret-type-spec-71 fails on 32-bit powerpc
  2023-09-14 13:02 ` bug#65978: " Eli Zaretskii
@ 2023-09-14 14:44   ` Andrea Corallo
  0 siblings, 0 replies; 9+ messages in thread
From: Andrea Corallo @ 2023-09-14 14:44 UTC (permalink / raw)
  To: Eli Zaretskii
  Cc: Andreas Schwab, debian-powerpc, 65978, John Paul Adrian Glaubitz

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: debian-powerpc <debian-powerpc@lists.debian.org>
>> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> Date: Thu, 14 Sep 2023 14:28:24 +0200
>> 
>> Hello!
>> 
>> The test comp-tests-ret-type-spec-71 reproducibly fails on 32-bit powerpc:
>> 
>> Test comp-tests-ret-type-spec-71 backtrace:
>>   signal(ert-test-failed (((should (equal (cl-third (subr-type (symbol
>>   ert-fail(((should (equal (cl-third (subr-type (symbol-function f-nam
>>   comp-tests-check-ret-type-spec((defun comp-tests-ret-type-spec-f (x)
>>   #f(compiled-function () #<bytecode -0x221c87d>)()
>>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>>   ert-run-test(#s(ert-test :name comp-tests-ret-type-spec-71 :document
>>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>>   ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
>>   ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
>>   ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
>>   command-line-1(("-L" ":/<<PKGBUILDDIR>>/debian/build
>>   command-line()
>>   normal-top-level()
>> Test comp-tests-ret-type-spec-71 condition:
>>     (ert-test-failed
>>      ((should
>>        (equal
>> 	(cl-third ...)
>> 	ret-type))
>>       :form
>>       (equal
>>        (or
>> 	(member 0.0 -0.0)
>> 	(integer 0 0))
>>        (or
>> 	(member -0.0 0.0)
>> 	(integer 0 0)))
>>       :value nil :explanation
>>       (list-elt 1
>> 		(list-elt 1
>> 			  (different-atoms 0.0 -0.0)))))
>>    FAILED  145/166  comp-tests-ret-type-spec-71 (0.399696 sec)
>
> Something about the sign of zero, I guess?  Adding Andreas, in the
> hope that he will have some suggestions.

Mmmh, I guess some of our sorting or compare function behaves
differently on this architecture... I'll try look closer at the code
tomorrow and try to guess something more precise.

Thanks

   Andrea





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#65978: comp-tests-ret-type-spec-71 fails on 32-bit powerpc
  2023-09-14 12:28 comp-tests-ret-type-spec-71 fails on 32-bit powerpc John Paul Adrian Glaubitz
  2023-09-14 13:02 ` bug#65978: " Eli Zaretskii
@ 2024-03-07 18:42 ` Andrea Corallo
  2024-03-14  8:28   ` Eli Zaretskii
  1 sibling, 1 reply; 9+ messages in thread
From: Andrea Corallo @ 2024-03-07 18:42 UTC (permalink / raw)
  To: John Paul Adrian Glaubitz; +Cc: debian-powerpc, 65978

John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> writes:

Hi John,

I *think* this should be fixed.  Could you verify and let us know if you
still see the issue?

Thanks

  Andrea





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#65978: comp-tests-ret-type-spec-71 fails on 32-bit powerpc
  2024-03-07 18:42 ` Andrea Corallo
@ 2024-03-14  8:28   ` Eli Zaretskii
  2024-03-21 10:21     ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2024-03-14  8:28 UTC (permalink / raw)
  To: glaubitz, Andrea Corallo; +Cc: debian-powerpc, 65978

> Cc: debian-powerpc <debian-powerpc@lists.debian.org>, 65978@debbugs.gnu.org
> From: Andrea Corallo <acorallo@gnu.org>
> Date: Thu, 07 Mar 2024 13:42:38 -0500
> 
> John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> writes:
> 
> Hi John,
> 
> I *think* this should be fixed.  Could you verify and let us know if you
> still see the issue?

Ping!  John, could you please verify the fix?

Thanks.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#65978: comp-tests-ret-type-spec-71 fails on 32-bit powerpc
  2024-03-14  8:28   ` Eli Zaretskii
@ 2024-03-21 10:21     ` Eli Zaretskii
  2024-03-21 10:39       ` John Paul Adrian Glaubitz
       [not found]       ` <48c638500670b656ea4a4346d29ac3ea59d09593.camel@physik.fu-berlin.de>
  0 siblings, 2 replies; 9+ messages in thread
From: Eli Zaretskii @ 2024-03-21 10:21 UTC (permalink / raw)
  To: glaubitz; +Cc: acorallo, debian-powerpc, 65978

> Cc: debian-powerpc@lists.debian.org, 65978@debbugs.gnu.org
> Date: Thu, 14 Mar 2024 10:28:22 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Cc: debian-powerpc <debian-powerpc@lists.debian.org>, 65978@debbugs.gnu.org
> > From: Andrea Corallo <acorallo@gnu.org>
> > Date: Thu, 07 Mar 2024 13:42:38 -0500
> > 
> > John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> writes:
> > 
> > Hi John,
> > 
> > I *think* this should be fixed.  Could you verify and let us know if you
> > still see the issue?
> 
> Ping!  John, could you please verify the fix?

Ping! Ping!





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#65978: comp-tests-ret-type-spec-71 fails on 32-bit powerpc
  2024-03-21 10:21     ` Eli Zaretskii
@ 2024-03-21 10:39       ` John Paul Adrian Glaubitz
       [not found]       ` <48c638500670b656ea4a4346d29ac3ea59d09593.camel@physik.fu-berlin.de>
  1 sibling, 0 replies; 9+ messages in thread
From: John Paul Adrian Glaubitz @ 2024-03-21 10:39 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: acorallo, debian-powerpc, 65978

Hi Eli,

On Thu, 2024-03-21 at 12:21 +0200, Eli Zaretskii wrote:
> > Cc: debian-powerpc@lists.debian.org, 65978@debbugs.gnu.org
> > Date: Thu, 14 Mar 2024 10:28:22 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > > Cc: debian-powerpc <debian-powerpc@lists.debian.org>, 65978@debbugs.gnu.org
> > > From: Andrea Corallo <acorallo@gnu.org>
> > > Date: Thu, 07 Mar 2024 13:42:38 -0500
> > > 
> > > John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> writes:
> > > 
> > > Hi John,
> > > 
> > > I *think* this should be fixed.  Could you verify and let us know if you
> > > still see the issue?
> > 
> > Ping!  John, could you please verify the fix?
> 
> Ping! Ping!

Sorry, I will give it another try today.

I am currently swamped in work due to Debian's time_t transition and
additional tasks at my day job.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#65978: comp-tests-ret-type-spec-71 fails on 32-bit powerpc
       [not found]       ` <48c638500670b656ea4a4346d29ac3ea59d09593.camel@physik.fu-berlin.de>
@ 2024-03-21 21:51         ` John Paul Adrian Glaubitz
       [not found]         ` <e916c3112ff506b56a2688ca2f4f388bb763d2b7.camel@physik.fu-berlin.de>
  1 sibling, 0 replies; 9+ messages in thread
From: John Paul Adrian Glaubitz @ 2024-03-21 21:51 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: acorallo, debian-powerpc, 65978

Hi,

On Thu, 2024-03-21 at 11:39 +0100, John Paul Adrian Glaubitz wrote:
> On Thu, 2024-03-21 at 12:21 +0200, Eli Zaretskii wrote:
> > > Cc: debian-powerpc@lists.debian.org, 65978@debbugs.gnu.org
> > > Date: Thu, 14 Mar 2024 10:28:22 +0200
> > > From: Eli Zaretskii <eliz@gnu.org>
> > > 
> > > > Cc: debian-powerpc <debian-powerpc@lists.debian.org>, 65978@debbugs.gnu.org
> > > > From: Andrea Corallo <acorallo@gnu.org>
> > > > Date: Thu, 07 Mar 2024 13:42:38 -0500
> > > > 
> > > > John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> writes:
> > > > 
> > > > Hi John,
> > > > 
> > > > I *think* this should be fixed.  Could you verify and let us know if you
> > > > still see the issue?
> > > 
> > > Ping!  John, could you please verify the fix?
> > 
> > Ping! Ping!
> 
> Sorry, I will give it another try today.
> 
> I am currently swamped in work due to Debian's time_t transition and
> additional tasks at my day job.

All tests pass for me on git master, so I assume the bug has been fixed.

I'm not 100% sure how to run the testsuite in the same way as the Debian
package though.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#65978: comp-tests-ret-type-spec-71 fails on 32-bit powerpc
       [not found]         ` <e916c3112ff506b56a2688ca2f4f388bb763d2b7.camel@physik.fu-berlin.de>
@ 2024-03-22  7:16           ` Eli Zaretskii
  0 siblings, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2024-03-22  7:16 UTC (permalink / raw)
  To: John Paul Adrian Glaubitz; +Cc: acorallo, debian-powerpc, 65978-done

> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Cc: acorallo@gnu.org, debian-powerpc@lists.debian.org, 65978@debbugs.gnu.org
> Date: Thu, 21 Mar 2024 22:51:59 +0100
> 
> Hi,
> 
> On Thu, 2024-03-21 at 11:39 +0100, John Paul Adrian Glaubitz wrote:
> > On Thu, 2024-03-21 at 12:21 +0200, Eli Zaretskii wrote:
> > > > Cc: debian-powerpc@lists.debian.org, 65978@debbugs.gnu.org
> > > > Date: Thu, 14 Mar 2024 10:28:22 +0200
> > > > From: Eli Zaretskii <eliz@gnu.org>
> > > > 
> > > > > Cc: debian-powerpc <debian-powerpc@lists.debian.org>, 65978@debbugs.gnu.org
> > > > > From: Andrea Corallo <acorallo@gnu.org>
> > > > > Date: Thu, 07 Mar 2024 13:42:38 -0500
> > > > > 
> > > > > John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> writes:
> > > > > 
> > > > > Hi John,
> > > > > 
> > > > > I *think* this should be fixed.  Could you verify and let us know if you
> > > > > still see the issue?
> > > > 
> > > > Ping!  John, could you please verify the fix?
> > > 
> > > Ping! Ping!
> > 
> > Sorry, I will give it another try today.
> > 
> > I am currently swamped in work due to Debian's time_t transition and
> > additional tasks at my day job.
> 
> All tests pass for me on git master, so I assume the bug has been fixed.

Thanks, I'm therefore closing this bug.

> I'm not 100% sure how to run the testsuite in the same way as the Debian
> package though.

I don't think this is our problem, but if I'm wrong, we can always
reopen the bug later with new information.





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-03-22  7:16 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-14 12:28 comp-tests-ret-type-spec-71 fails on 32-bit powerpc John Paul Adrian Glaubitz
2023-09-14 13:02 ` bug#65978: " Eli Zaretskii
2023-09-14 14:44   ` Andrea Corallo
2024-03-07 18:42 ` Andrea Corallo
2024-03-14  8:28   ` Eli Zaretskii
2024-03-21 10:21     ` Eli Zaretskii
2024-03-21 10:39       ` John Paul Adrian Glaubitz
     [not found]       ` <48c638500670b656ea4a4346d29ac3ea59d09593.camel@physik.fu-berlin.de>
2024-03-21 21:51         ` John Paul Adrian Glaubitz
     [not found]         ` <e916c3112ff506b56a2688ca2f4f388bb763d2b7.camel@physik.fu-berlin.de>
2024-03-22  7:16           ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).