unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Pettersson <daniel@dpettersson.net>
Cc: joaotavora@gmail.com, 70522-done@debbugs.gnu.org,
	azeng@janestreet.com, app-emacs-dev@janestreet.com
Subject: bug#70522: 29.2.50; eglot-shutdown sends SIGKILL before LSP server can exit gracefully
Date: Sat, 27 Apr 2024 12:20:17 +0300	[thread overview]
Message-ID: <86frv7w4a6.fsf@gnu.org> (raw)
In-Reply-To: <m27cgo2ezl.fsf@dpettersson.net> (message from Daniel Pettersson on Tue, 23 Apr 2024 18:58:06 +0200)

> From: Daniel Pettersson <daniel@dpettersson.net>
> Cc: Aaron Zeng <azeng@janestreet.com>,  70522@debbugs.gnu.org,
>   app-emacs-dev@janestreet.com,  João Távora
>  <joaotavora@gmail.com>
> Date: Tue, 23 Apr 2024 18:58:06 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Daniel, could you please look into this issue?
> 
> Change makes sense, the only "risk" is that jsonrpc users populate the
> *Warnings* buffer with an warning that they should take action upon and
> solve, so I think this is an no brainer.
> 
> Nice job!
> 
> I have done some adhock testing of eglot and dape. Was not able to
> produce the warning, which means that eglot and dape are using the
> function as intended (at least when interacting with the servers I
> tested with).
> 
> When the function is touched I would like to do some small additions to
> the documentation of the function, would be nice if the docstring
> mention the undocumented behavior and an small comment to make it a bit
> easier to follow along. 

Thanks, installed on master, and closing the bug.





      reply	other threads:[~2024-04-27  9:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 21:39 bug#70522: 29.2.50; eglot-shutdown sends SIGKILL before LSP server can exit gracefully Aaron Zeng
2024-04-23  5:51 ` Eli Zaretskii
2024-04-23 16:58   ` Daniel Pettersson
2024-04-27  9:20     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86frv7w4a6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70522-done@debbugs.gnu.org \
    --cc=app-emacs-dev@janestreet.com \
    --cc=azeng@janestreet.com \
    --cc=daniel@dpettersson.net \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).