From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body Date: Sat, 27 Apr 2024 22:18:09 +0300 Message-ID: <86frv6vclq.fsf@gnu.org> References: <87o7afod31.fsf@gmail.com> <87mspusb5k.fsf@thornhill.no> <87wmopaii8.fsf@gmail.com> <867cgl1la9.fsf@gnu.org> <875xw2et3e.fsf@pub.pink> <86h6fmvmm0.fsf@gnu.org> <87edaq3evk.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 70345@debbugs.gnu.org, theo@thornhill.no, jacobtophatleeming@gmail.com To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 27 21:19:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0nZd-00012Q-JG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Apr 2024 21:19:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0nZM-0004jd-3p; Sat, 27 Apr 2024 15:18:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0nZL-0004j2-CF for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 15:18:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0nZL-0006XI-3m for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 15:18:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0nZd-00059o-Oe for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 15:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2024 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70345-submit@debbugs.gnu.org id=B70345.171424552319802 (code B ref 70345); Sat, 27 Apr 2024 19:19:01 +0000 Original-Received: (at 70345) by debbugs.gnu.org; 27 Apr 2024 19:18:43 +0000 Original-Received: from localhost ([127.0.0.1]:49702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0nZK-00059K-Vo for submit@debbugs.gnu.org; Sat, 27 Apr 2024 15:18:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0nZH-00059E-Uz for 70345@debbugs.gnu.org; Sat, 27 Apr 2024 15:18:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0nYs-0006Tz-VW; Sat, 27 Apr 2024 15:18:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ih2ZifgWTQEjF9Q/9J+vYvJHR9ZbyvUStWQdE/09S5g=; b=R+/lfPsQI2VJ5+14I/wx sEnrzjFjmG48RjwqgvFzvCsoR+2vEPmnJPOpKfXyAFvC/q5aI9kRhaJ4d0qLEvF0Yi566mw3xGBJL NtEr5pEVCXFGgnJcqKptCjt07qPEY3sSnsfV22t0xq7xFemQIyZR7OtvDm38PK5Ac2C7QaSAVJuId 8W0RYKydomnUftRSl+oSSxDYAPrm6w7SFn68kNxb4zugcLupZ00VX3kyff4MwtGCKV94ZpZPsujlQ mXngd6atTKn+g4WAy3WegHPVQXEX+LEbgniMwTgUz1gPBFpd8gfXL1ptXgn4TIxCN+i3vWUM3JNO/ SNIRQET3ZMCjuQ==; In-Reply-To: <87edaq3evk.fsf@pub.pink> (message from john muhl on Sat, 27 Apr 2024 12:13:12 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284062 Archived-At: > From: john muhl > Cc: jacobtophatleeming@gmail.com, dmitry@gutov.dev, 70345@debbugs.gnu.org, > theo@thornhill.no > Date: Sat, 27 Apr 2024 12:13:12 -0500 > > Eli Zaretskii writes: > > > Thanks, but shouldn't we invoke treesit-ready-p with second argument > > non-nil? > > Looks like it’s gone either way so far. "Two wrongs don't make a right." Without the 2nd arg, the function complains: Warning (treesit): Cannot activate tree-sitter, because language grammar for c-sharp is unavailable (not-found): (libtree-sitter-c-sharp libtree-sitter-c-sharp.dll) No such file or directory skipped 2/2 csharp-ts-mode-test-indentation (0.007771 sec) So I've added the 2nd argument to your patch and installed it on the emacs-29 branch. Thanks.