unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: john muhl <jm@pub.pink>
Cc: dmitry@gutov.dev, 70345@debbugs.gnu.org, theo@thornhill.no,
	jacobtophatleeming@gmail.com
Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body
Date: Sat, 27 Apr 2024 22:18:09 +0300	[thread overview]
Message-ID: <86frv6vclq.fsf@gnu.org> (raw)
In-Reply-To: <87edaq3evk.fsf@pub.pink> (message from john muhl on Sat, 27 Apr 2024 12:13:12 -0500)

> From: john muhl <jm@pub.pink>
> Cc: jacobtophatleeming@gmail.com, dmitry@gutov.dev, 70345@debbugs.gnu.org,
>  theo@thornhill.no
> Date: Sat, 27 Apr 2024 12:13:12 -0500
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Thanks, but shouldn't we invoke treesit-ready-p with second argument
> > non-nil?
> 
> Looks like it’s gone either way so far.

"Two wrongs don't make a right."  Without the 2nd arg, the function
complains:

  Warning (treesit): Cannot activate tree-sitter, because language grammar for c-sharp is unavailable (not-found): (libtree-sitter-c-sharp libtree-sitter-c-sharp.dll) No such file or directory
    skipped  2/2  csharp-ts-mode-test-indentation (0.007771 sec)

So I've added the 2nd argument to your patch and installed it on the
emacs-29 branch.

Thanks.





      reply	other threads:[~2024-04-27 19:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 20:32 bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body Jacob Leeming
2024-04-12  5:45 ` Eli Zaretskii
2024-04-14 23:02 ` Yuan Fu
2024-04-15  4:56   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 19:01 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 21:38   ` Jacob Leeming
2024-04-16  0:27     ` Dmitry Gutov
2024-04-22  8:50   ` Jacob Leeming
2024-04-25 16:04     ` Eli Zaretskii
2024-04-26 13:53       ` Jacob Leeming
2024-04-26 15:24         ` Eli Zaretskii
2024-04-27 13:10       ` john muhl
2024-04-27 15:41         ` Eli Zaretskii
2024-04-27 17:13           ` john muhl
2024-04-27 19:18             ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86frv6vclq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70345@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=jacobtophatleeming@gmail.com \
    --cc=jm@pub.pink \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).