From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71374: [PATCH] Simplify 'help-enable-variable-value-editing' using Date: Wed, 05 Jun 2024 15:19:39 +0300 Message-ID: <86frtrk2ec.fsf@gnu.org> References: <87ikync1zh.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="323"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71374@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 05 14:25:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEphu-000APP-9t for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jun 2024 14:25:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEphC-0001FL-AA; Wed, 05 Jun 2024 08:24:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEphB-0001Eq-Dd for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 08:24:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEphB-0001xw-5B for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 08:24:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEphP-0003Vz-2k for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 08:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 12:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71374 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71374-submit@debbugs.gnu.org id=B71374.171759027213410 (code B ref 71374); Wed, 05 Jun 2024 12:25:03 +0000 Original-Received: (at 71374) by debbugs.gnu.org; 5 Jun 2024 12:24:32 +0000 Original-Received: from localhost ([127.0.0.1]:57509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEpgt-0003UB-Ho for submit@debbugs.gnu.org; Wed, 05 Jun 2024 08:24:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEpgp-0003TO-DT for 71374@debbugs.gnu.org; Wed, 05 Jun 2024 08:24:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEpcJ-0000Hq-P1; Wed, 05 Jun 2024 08:19:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8HjwwUj3ccXC9n+y8OxlR+V3A+KHU9xhbzdX7I/JUrs=; b=WQOZJE0fpOpJ IHJGiB31priRLQvY5GWyNHZgQ1c26WwWs5Un4JGfT1nUv7MTcDvG1eWqwyiesXhokbGWZFrWBQveR OTzN4qxLji5ypsQU/s7TPeuJqMJssuSwN7lMBnEutVJ7XRi4KjABbL3YtWZRhl67rCSza1TVthkvc dvp6dt6blP+4VFXiW+5wJX9futlPBI335g/t6pF6EeAgRVFl1vaV6kOmNqZ/PlCTxfq1KosLWrhPB dOwEw/xE4p70XgKUYqxJQINLM98LZoNMnDqHtl7Hg5RmymtelzO3/pyf8Os+x9RAD4Jn5ZwtM8aos MS8ffaBl1y+1/33TMr2v/w==; In-Reply-To: <87ikync1zh.fsf@posteo.net> (message from Philip Kaludercic on Wed, 05 Jun 2024 06:55:46 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286599 Archived-At: > From: Philip Kaludercic > Date: Wed, 05 Jun 2024 06:55:46 +0000 > > The main issue with this patch is that it drops the syntax highlighting > in the *string edit* buffer, but we could fix that in a second patch by > adding support to specify a major mode to inherit from when editing a > string. Thanks. This is basically a cleanup, yes? IOW, there's nothing wrong with the current implementation, right? If so, I'd prefer to wait with this until after the emacs-30 branch is cut.