From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Sun, 16 Jun 2024 09:58:10 +0300 Organization: LINKOV.NET Message-ID: <86frtdtlns.fsf@mail.linkov.net> References: <86ikymipzx.fsf@gnu.org> <7269c7c4-86a1-44bf-8d5d-378c3584027a@gmx.at> <86zfrx8ec0.fsf@mail.linkov.net> <8561a63a-66d3-44cd-872f-73d26af7edbe@gmx.at> <86msnw4qm4.fsf@mail.linkov.net> <86y17gej2x.fsf@gnu.org> <86y17gmxdg.fsf@mail.linkov.net> <868qzehxie.fsf@mail.linkov.net> <86msnu9fhg.fsf@gnu.org> <86zfruc7qh.fsf@mail.linkov.net> <86ikyi9e2l.fsf@gnu.org> <86o78ac6ny.fsf@mail.linkov.net> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@gmx.at> <86frtkeyzo.fsf@mail.linkov.net> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@gmx.at> <86r0d1iaxc.fsf@mail.linkov.net> <8634pfe735.fsf@mail.linkov.net> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5305"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , abdo.haji.ali@gmail.com, 71386@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 16 09:05:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIjx9-0001FG-FT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jun 2024 09:05:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIjwk-0000PX-2y; Sun, 16 Jun 2024 03:05:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIjwj-0000PI-6Z for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 03:05:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIjwi-0001qy-Tu for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 03:05:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sIjwj-0003nq-SU for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 03:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2024 07:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71386 X-GNU-PR-Package: emacs Original-Received: via spool by 71386-submit@debbugs.gnu.org id=B71386.171852149114583 (code B ref 71386); Sun, 16 Jun 2024 07:05:01 +0000 Original-Received: (at 71386) by debbugs.gnu.org; 16 Jun 2024 07:04:51 +0000 Original-Received: from localhost ([127.0.0.1]:59445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIjwZ-0003n8-0J for submit@debbugs.gnu.org; Sun, 16 Jun 2024 03:04:51 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:35275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIjwX-0003mm-1n for 71386@debbugs.gnu.org; Sun, 16 Jun 2024 03:04:49 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id CABE340002; Sun, 16 Jun 2024 07:04:20 +0000 (UTC) In-Reply-To: <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@gmx.at> (martin rudalics's message of "Sat, 15 Jun 2024 10:42:05 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287324 Archived-At: > +(defvar window-delete-frame-functions nil > + "A list of functions to handle the frame deletion. > > I'd still prefer a tab-bar specific option (like 'tab-bar-save-frame-p' > as mentioned earlier) for two reasons. > > The first reason is that 'window--delete' is an internal function of > window.el. I wouldn't want an internal function run a hook "of its own" > because that's difficult to explain to users. OTOH I suppose that a > function like 'tab-bar-save-frame-p' should be callable from any other > function too, as soon as the need arises. > > The second reason is that I wouldn't want "anyone" to inhibit frame > deletion. Such a facility could have consequences I cannot fathom at > the moment. Would we want 'delete-frame' to obey it too and possibly > spare the frame? Ok, here is the right patch: diff --git a/lisp/window.el b/lisp/window.el index b7bd59bc813..872110a8321 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4120,6 +4120,8 @@ window-deletable-p (let ((frame (window-frame window))) (cond + ((and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)) + 'tab) ((frame-root-window-p window) ;; WINDOW's frame can be deleted only if there are other frames ;; on the same terminal, and it does not contain the active @@ -4979,6 +4981,9 @@ window--delete (unless (and dedicated-only (not (window-dedicated-p window))) (let ((deletable (window-deletable-p window))) (cond + ((eq deletable 'tab) + (tab-bar-close-tab) + 'tab) ((eq deletable 'frame) (let ((frame (window-frame window))) (cond