From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71733: 29.3; tab-bar-tab-group-face-default invokes tab-bar-tab-face-default incorrectly? Date: Sun, 23 Jun 2024 20:30:48 +0300 Organization: LINKOV.NET Message-ID: <86frt3r2gn.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8320"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Adam Porter , 71733@debbugs.gnu.org To: Ship Mints Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 23 19:44:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLRGE-00022F-QL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jun 2024 19:44:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLRFz-00007e-MB; Sun, 23 Jun 2024 13:44:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLRFy-00007H-Si for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 13:44:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLRFy-0002ga-Ks for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 13:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLRFz-0004pD-5S for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 13:44:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 17:44:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71733 X-GNU-PR-Package: emacs Original-Received: via spool by 71733-submit@debbugs.gnu.org id=B71733.171916459918413 (code B ref 71733); Sun, 23 Jun 2024 17:44:03 +0000 Original-Received: (at 71733) by debbugs.gnu.org; 23 Jun 2024 17:43:19 +0000 Original-Received: from localhost ([127.0.0.1]:42707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLRFH-0004mu-4V for submit@debbugs.gnu.org; Sun, 23 Jun 2024 13:43:19 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:44631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLRFG-0004mY-2Q; Sun, 23 Jun 2024 13:43:18 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id E1318C0005; Sun, 23 Jun 2024 17:43:09 +0000 (UTC) In-Reply-To: (Ship Mints's message of "Sun, 23 Jun 2024 07:22:37 -0400") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287798 Archived-At: tags 71733 wontfix close 71733 30.0.50 thanks > `tab-bar-tab-group-face-default' hard codes the invocation to > `tab-bar-tab-face-default' but should it instead invoke > `tab-bar-tab-face-function' to benefit from a custom function? > > (defun tab-bar-tab-group-face-default (tab) > (if (not (or (eq (car tab) 'current-tab) > (funcall tab-bar-tab-group-function tab))) > 'tab-bar-tab-ungrouped > (tab-bar-tab-face-default tab))) > ;; should the last line be something like this? > (funcall tab-bar-tab-face-function tab))) > > I checked the latest `tab-bar' source code this morning and this hasn't yet > been addressed, if indeed this is unintended behavior. Sorry, this can't be changed because it will cause an infinite recursion. You can see in 'tab-bar-format-tabs-groups': (let ((tab-bar-tab-face-function tab-bar-tab-group-face-function)) (tab-bar--format-tab tab i)) Then with the default value 'tab-bar-tab-group-face-default' of 'tab-bar-tab-group-face-function', 'tab-bar-tab-face-function' in 'tab-bar-tab-group-face-default' will recursively call itself.