From: Juri Linkov <juri@linkov.net>
To: Ship Mints <shipmints@gmail.com>
Cc: Adam Porter <adam@alphapapa.net>, 71733@debbugs.gnu.org
Subject: bug#71733: 29.3; tab-bar-tab-group-face-default invokes tab-bar-tab-face-default incorrectly?
Date: Sun, 23 Jun 2024 20:30:48 +0300 [thread overview]
Message-ID: <86frt3r2gn.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAN+1HbpRQyi5Coj5VwY+KOYbSWBwR7wAHxxQ3qg4TcUEaXmvow@mail.gmail.com> (Ship Mints's message of "Sun, 23 Jun 2024 07:22:37 -0400")
tags 71733 wontfix
close 71733 30.0.50
thanks
> `tab-bar-tab-group-face-default' hard codes the invocation to
> `tab-bar-tab-face-default' but should it instead invoke
> `tab-bar-tab-face-function' to benefit from a custom function?
>
> (defun tab-bar-tab-group-face-default (tab)
> (if (not (or (eq (car tab) 'current-tab)
> (funcall tab-bar-tab-group-function tab)))
> 'tab-bar-tab-ungrouped
> (tab-bar-tab-face-default tab)))
> ;; should the last line be something like this?
> (funcall tab-bar-tab-face-function tab)))
>
> I checked the latest `tab-bar' source code this morning and this hasn't yet
> been addressed, if indeed this is unintended behavior.
Sorry, this can't be changed because it will cause an infinite recursion.
You can see in 'tab-bar-format-tabs-groups':
(let ((tab-bar-tab-face-function
tab-bar-tab-group-face-function))
(tab-bar--format-tab tab i))
Then with the default value 'tab-bar-tab-group-face-default'
of 'tab-bar-tab-group-face-function', 'tab-bar-tab-face-function'
in 'tab-bar-tab-group-face-default' will recursively call itself.
prev parent reply other threads:[~2024-06-23 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 11:22 bug#71733: 29.3; tab-bar-tab-group-face-default invokes tab-bar-tab-face-default incorrectly? Ship Mints
2024-06-23 17:30 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86frt3r2gn.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=71733@debbugs.gnu.org \
--cc=adam@alphapapa.net \
--cc=shipmints@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).