From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable Date: Wed, 21 Aug 2024 16:27:01 +0300 Message-ID: <86frqyuhui.fsf@gnu.org> References: <86wmkbujh5.fsf@gnu.org> <875xrvhtll.fsf@> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72735@debbugs.gnu.org To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 21 15:28:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sglO6-000ASo-BJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Aug 2024 15:28:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sglNs-0007e2-2x; Wed, 21 Aug 2024 09:28:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sglNq-0007cI-BF for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 09:28:18 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sglNq-0003Sr-27 for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 09:28:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=QCRhMzS71UyGpwqXsA2SZkraF2XddoqCOqgC0Yg5G1w=; b=eo0pl2QR7CL0h7YO1wjznn7zVqWEyJat2CaOSlV/qv9YKJAU1UWfzPg7FQJhMv4kJyQY4EnEnNcqMfH1l59qCLM/gFfqGR+Wc0RVTTRLcdqGUVzPZJ8Z0y41I47JTKMFMfpHnonzdbywOSwaqCLYuasjZ1thVyYht/A/Rf0LXy141ttVkWDXHhuUlyG+fp5gC66Ts2OZoQEsxUqQ4I8bUA2ARmmsBcQjqPiAWf/3Hel8dISBZGnU/TdpU12QQz4KF81hCqmWXlegpoEw7KLqWLu8LNEkiNvzF3MV6s/43A8e3wSromXuieG3b8OR5lMFNNaoVPKSDQW6j/onIMnF8w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sglOY-0002th-7p for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 09:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2024 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72735 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72735-submit@debbugs.gnu.org id=B72735.172424689711080 (code B ref 72735); Wed, 21 Aug 2024 13:29:02 +0000 Original-Received: (at 72735) by debbugs.gnu.org; 21 Aug 2024 13:28:17 +0000 Original-Received: from localhost ([127.0.0.1]:35193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sglNo-0002sd-Md for submit@debbugs.gnu.org; Wed, 21 Aug 2024 09:28:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sglNj-0002sN-9S for 72735@debbugs.gnu.org; Wed, 21 Aug 2024 09:28:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sglMs-000337-P6; Wed, 21 Aug 2024 09:27:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=QCRhMzS71UyGpwqXsA2SZkraF2XddoqCOqgC0Yg5G1w=; b=Tcyb5+2GV9NQRsSjQmpl 9eN0+nZcuy0I8/5MOOX6NHSf2Skxs3rCqjM5atxv3GSR8qtY3TWpJxmXCRxX0pqzewdvZZpi9aLoA ISV4dGW2H8RLoYnXNOgwkdInLQ+/27E/PfGETZgdRj/FCDS91yQHZmqgM9I927dWmXsiEhQHfDVSp HN5rnOiDRSLQjmCuFyWxNTttJcEZM/wIR6Z5mMRBsAl9b4MT+CWd4bvIVEyFWqtRE6iOET2yhgLMX V0x2pKfEeffGLQQVy3+qqymycfh2d/mLKTtpBTHcmp3dROH/+yT8ekyNDV8pPYpI8DfRozANuvBQS luzfOpqO4c+7Xw==; In-Reply-To: <875xrvhtll.fsf@> (message from =?UTF-8?Q?Bj=C3=B6rn?= Bidar on Tue, 20 Aug 2024 22:39:18 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290488 Archived-At: > From: Björn Bidar > Cc: 72735@debbugs.gnu.org > Date: Tue, 20 Aug 2024 22:39:18 +0300 > > >> +FORGE-TYPE is the type of the forge, e.g., gitlab, gitea, > >> +sourcehut, or github. > > > > This leaves it unsaid how these symbols are used, and what symbols are > > recognized. > > Does the original text not say that already? The choices over all the > existing symbols which are accepted, if it doesn't make sense to > e.g. add a custom symbol to extend the mode than removing the (symbol) > choice is good. It might be enough to say that those symbols are the only predefined ones. The text as it is leaves the impression that they are only examples. Also, something should be said regarding the differences between the symbols: why does the user need to specify these symbols and what could happen if they use a wrong symbol? > > Finally, I think this warrants a NEWS entry. > > Should the news entry explain similarly that the variables can be set > with defcustom and have improved documentation? Just the fact that they are now user options, that's all.