From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Date: Thu, 22 Aug 2024 12:59:42 +0300 Message-ID: <86frqwubch.fsf@gnu.org> References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22984"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 22 12:01:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sh4cw-0005mY-D4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Aug 2024 12:01:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sh4ci-0003Sd-Fg; Thu, 22 Aug 2024 06:00:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sh4cb-0003SN-VS for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 06:00:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sh4c4-00038U-Ae for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 06:00:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=ImV/DtXLTQAy7t1p8q9UsYdJS6kL//GmIRvNkUnAugE=; b=aYS9wnctzFiopee4ORw+KKv7EZXRiYiZND5REUkuDbxVOhQOS5PwivqA3QsDrB1HUwoFGRJjpXKktkc83N6kschPBEHVC0/bbcL3EUeVHK1pXjLMou1CEmQ4x/rUV3eil0bfzzps4EQFvX/gWGNNK98bJifij6bMqss3ZQArm2MlJfyTPimBy2cuR/TcSMGt8ojcUrYZO8zUdC7+7D4ktWkPr87ai9DSktcer9YenSTC0ivwB039pMsQf3gYDXPenzRhk8E9bV6StD5H3KxDNySM94lD7hsc0SPQHmbTfE+AfF0h5uMo7M1W8GF+RVV0/C+vV1jO2giOu8qvo9A/VA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sh4cn-0004aI-Sk for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 06:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Aug 2024 10:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72721 X-GNU-PR-Package: emacs Original-Received: via spool by 72721-submit@debbugs.gnu.org id=B72721.172432084017580 (code B ref 72721); Thu, 22 Aug 2024 10:01:01 +0000 Original-Received: (at 72721) by debbugs.gnu.org; 22 Aug 2024 10:00:40 +0000 Original-Received: from localhost ([127.0.0.1]:36763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh4cS-0004ZU-Io for submit@debbugs.gnu.org; Thu, 22 Aug 2024 06:00:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh4cQ-0004Z7-80 for 72721@debbugs.gnu.org; Thu, 22 Aug 2024 06:00:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sh4ba-0002mP-CM; Thu, 22 Aug 2024 05:59:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ImV/DtXLTQAy7t1p8q9UsYdJS6kL//GmIRvNkUnAugE=; b=ocaMhrYudQug QZtbk7awdhDnnIS0KeGUujwe3R0GR5cPNQnnFO5uQQ/xdVKedINL4WLj/xZvfM3yrA7NcwXTp/g+O vkvBmfkXkO47n3ONiybEsxf4wCurnh5Wpt3ZFcxz97xpG4yjfCjL+Wpgk3/VZev3pgGbH1PmaKts7 82PywFKSAVBCZxUSlyFRQKM6BA3RRs7Lq0maw2YgoGlF4qZKGK4bv3cpdK3Mc/1ODULeszPckRa+u 5nbqwc8QLs/GJjN22B/SLRwdW4Q7ESQMew06xRT9KAAtVYqp/eGlVaZxUSLbEbPON/HhhbVnAkIJW eRe7MGIQ0iKfrAT/n937Ig==; In-Reply-To: (message from Jim Porter on Tue, 20 Aug 2024 22:18:11 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290520 Archived-At: > Date: Tue, 20 Aug 2024 22:18:11 -0700 > From: Jim Porter > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > > Whoops, I'd uploaded the wrong patch. Here's the correct one. Thanks. I eventually decided to make the logic in display_min_width more robust wrt buffer vs string case, and also tried to handle the case of min-width property on Lisp strings, see the patch I sent. The case of min-width display spec on an overlay string that covers buffer text which itself has min-width spec is not handled yet, I think. Not sure this is needed, but if it is, we could add it in the future as an enhancement.