From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60423: 29.0.60; goto-address and shr/textsec don't play nicely together Date: Sat, 02 Nov 2024 13:10:27 +0200 Message-ID: <86fro9zyak.fsf@gnu.org> References: <175894.1672372745@alto> <831qoh6j0i.fsf@gnu.org> <69964.1728432546@alto.camomileplus.org> <86jzeh4g7x.fsf@gnu.org> <66867.1729115569@alto.camomileplus.org> <86ed41al4q.fsf@gnu.org> <32125.1730057061@alto.camomileplus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36143"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60423@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 02 12:11:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7C2I-0009Ha-NZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Nov 2024 12:11:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7C27-0005zy-94; Sat, 02 Nov 2024 07:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7C22-0005iC-SX for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 07:11:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7C22-0004kC-JV for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 07:11:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=8rdHQglp5yi5yqWFXuXKfyNnO4YMPx5PTrqad55Oup0=; b=EZjXxvoy8lKPkNhda6D6F5f016eGmyRgOE7itj1EhzGXonmNbVZ56dg+t5h/k1z/sLR+i5+npjIwtnRkM/exrlzI3xzdZMPVjaQyW5XnMqQe0jDF+feRzEWzE4lFqghB704C3KOn3NKJAeQmRfp0EoASvqGQJiCh7xY7TSPzhRtVfn6UIyHWlcdnenTLjhhp+HwqMjZ7En8nu+4btAZbp8wHGifdseNaah3nZ1v2Aj3cuBUeGFGu/L9ShWCArax6EMWS/In+/SvFcDG/VHohyWLQeFksp0z7Ir6HDElJnBvgihodUZ6UFNC9t9nwuyCSSB4ly12+MRksfpB0UUhUpQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t7C21-0007GV-Pz for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 07:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Nov 2024 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60423 X-GNU-PR-Package: emacs Original-Received: via spool by 60423-submit@debbugs.gnu.org id=B60423.173054584227915 (code B ref 60423); Sat, 02 Nov 2024 11:11:01 +0000 Original-Received: (at 60423) by debbugs.gnu.org; 2 Nov 2024 11:10:42 +0000 Original-Received: from localhost ([127.0.0.1]:53287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7C1h-0007GB-VU for submit@debbugs.gnu.org; Sat, 02 Nov 2024 07:10:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7C1f-0007G3-Rl for 60423@debbugs.gnu.org; Sat, 02 Nov 2024 07:10:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7C1X-0004PJ-5E; Sat, 02 Nov 2024 07:10:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=8rdHQglp5yi5yqWFXuXKfyNnO4YMPx5PTrqad55Oup0=; b=rRMQqd83WVBwL8hpFEe9 1zY93t+atWYyG0VWFKh72jX5xe1NF7DG40ZeYGWRaOW6kjfQRa1XoeaL07SqYC5C+hn/nllMKPEz5 4b8cJdbGguvE5Bj0PSJ6qkdHaSFcQtUp6PHdQLQm3+ebv+67dDc65u884RqYw1J4BXPj0qlQrwmbr p/Mxu/8DRC1nTvzsDlLneciKJ+q4LlkZ0t2e/TOI/lDJ4bxGouQh40bXOHDIJGdipa99ZmB1tY2Ed Mfnt2/hYbyrt4Iwm2yvHi35CHsri/m38KhpoVyJkuQ5OQO6lDTzV3lVUxuQ941WhmiQH4J37uI4Lw k08ObDaNS3ZJIg==; In-Reply-To: <32125.1730057061@alto.camomileplus.org> (message from Mike Kupfer on Sun, 27 Oct 2024 12:24:21 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294728 Archived-At: > From: Mike Kupfer > cc: monnier@iro.umontreal.ca, 60423@debbugs.gnu.org, stefankangas@gmail.com > Comments: In-reply-to Eli Zaretskii > message dated "Sun, 27 Oct 2024 12:35:49 +0200." > Date: Sun, 27 Oct 2024 12:24:21 -0700 > > Eli Zaretskii wrote: > > > > From: Mike Kupfer > [...] > > > Stefan Monnier wrote: > [...] > > > > Maybe it should check for the presence of `help-echo and (follow-link > > > > or keymap)`? And make sure the those properties cover exactly the same > > > > chunk of text? > > > > > > As far as covering the same chunk of text, I'll need to play with this > > > some more to see what works. shr-tag-a inserts a warning emoji with a > > > help-echo property, which goto-address somehow manages to clobber. That > > > warning emoji is not something goto-address would normally be looking > > > for. > > > > Ping! How can we make some progress with this bug report? > > I did figure out why goto-address is clobbering the help-echo property > on the warning emoji. goto-address uses goto-address-url-regexp to > identify URLs. shr puts the emoji immediately after the suspicious URL, > and apparently the regexp includes the emoji as part of the URL. > > https://badurl.com⚠️ > > I haven't completely reverse-engineered the regexp. I see that it's > built from a list of URI schemes and thing-at-point-url-path-regexp. > Maybe thing-at-point-url-path-regexp needs to be pickier? But I don't > understand how things should work in light of internationalized URLs. > > I've thought about having goto-address bail out if there are any > conflicting properties in the range that it wants to overlay, but I > haven't had time to prototype it to see how well that works. > > I suppose another possibility would be to move the warning emoji: put it > in front of the suspicious URL, rather than after the URL. > > WDYT? Maybe moving the warning emoji to the front is the easiest and the most robust solution.