From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74413: [PATCH] Allow to store and read repository information of VCS builds Date: Mon, 18 Nov 2024 14:45:27 +0200 Message-ID: <86frnovhg8.fsf@gnu.org> References: <87wmh1j6po.fsf@> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16888"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74413@debbugs.gnu.org To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 18 13:46:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tD19I-0004Cv-3V for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Nov 2024 13:46:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tD18u-0002om-AV; Mon, 18 Nov 2024 07:46:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD18l-0002oG-7M for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 07:46:08 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tD18k-0005Kl-5B for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 07:46:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=qf1uKMQOTqFV9KJfKuZrb/y6IT3RU/uJBswGC1HCSks=; b=vvgQF1DcTFPdYZXB7H35rAxTOIlgSJs6C0+NIW7ufuHN2g3uvv3hcJxZhcb3tkHc+FWu91lE3XQCi7CVYLGEXOX3EXoOU5wD6vwBG5dAS4xXXWDZ4TqRyN/TueW/7qq+74LleGlaAlnrb8PQH0gMNdAkkLqguWWmShX5Rb4vqfZQaolfUPFP1VO16o6KvdGU02rfpPaY/F//o4a7wkX8VIQqWOWO88GW0fSk7BTAPLPFyCZi/WZ+uCZQbjyaammDqEReAz0qHGXbcxrzsQ64aiHdlMuIKQd51bycvK5DgE5wuGb4ONXqSdnVnrZ8SzT58lqBNuybbC+Nq6DSXtq1oQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tD18j-0008UO-W8 for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 07:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2024 12:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74413-submit@debbugs.gnu.org id=B74413.173193394032604 (code B ref 74413); Mon, 18 Nov 2024 12:46:01 +0000 Original-Received: (at 74413) by debbugs.gnu.org; 18 Nov 2024 12:45:40 +0000 Original-Received: from localhost ([127.0.0.1]:60444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD18N-0008To-G9 for submit@debbugs.gnu.org; Mon, 18 Nov 2024 07:45:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD18L-0008Tb-O7 for 74413@debbugs.gnu.org; Mon, 18 Nov 2024 07:45:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD18F-0005JJ-Jh; Mon, 18 Nov 2024 07:45:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=qf1uKMQOTqFV9KJfKuZrb/y6IT3RU/uJBswGC1HCSks=; b=DZ+CqsTXRa3Q35EiZaSX rxqLkAFFQACKcmN9ZPNw4S0D/+1R/JSIB1OouhHY4io+G3qtAJS+xwSxRrZBGkibJ8iukzIzpF0Ok fZIV2gxRqynwMy/Ia4nsKhKyf4+VWaDe+HlxpxckMph3OYjH+TgoQTnX1dTKnuvAoNQIJwJ+VFkL/ 7LwijWnokgDQnDjXUCxngcTNbV8nyZPvStQ8QlTuZinNmvS5PT9jy8KsVuqGYqrWmNYcQ9ko/3xKU WvctS2mxRwYTg+3E6B4rr2SOh5XfLRl1/wsIBT8syFLgmTucCJ2v4l6jt9TlEdr/8X9KsGx/2Bmt7 TSn3kbig0hIOlw==; In-Reply-To: <87wmh1j6po.fsf@> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295592 Archived-At: > Date: Mon, 18 Nov 2024 10:18:11 +0200 > From: Björn Bidar via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Emacs has the feature to read the repository version and > branch if git is installed during the build and afterwards if also > the sources including the VCS repository is present. > > For the Android builds the feature was added to store and read the > information mentioned above in a special version file. Po Lu, why is that needed in the Android build, and how is it used there? > This patch reuses that mechanism so it can be reused on other platforms > to use for the same reasons its available for Android and to also be > able to use the information on CI workers without git installed and/or a > full source checkout. Doesn't that go against the tendency to have _less_ detailed/private information in the build? We've lately removed some relatively useful infos from what we report in commands that use the build information. More generally, could you present the motivation and the rationale for making this information available in production builds? > The things I'm not sure about for this patch are: > - Is the generating of the version file in the right place in > Makefile.in It should be in the build tree, yes. > - Is the data directory the right place to store the file Not sure, but I don't see why not. > - Should the creation of the version file be shared between the Android > builds and the other platforms Let's first discuss whether this is at all needed and a good idea, okay? > - ${INSTALL_PROGRAM} $(INSTALL_STRIP) src/emacs${EXEEXT} "$(DESTDIR)${bindir}/$(EMACSFULL)" > + ${INSTALL_PROGRAM} $(INSTALL_STRIP) src/emacs${EXEEXT} "$(DESTDIR)${bindir}/$(EMACS)" Why this change (and other similar ones)? What does EMACSFULL have to do with the repository version data? > @@ -826,6 +837,7 @@ install-man: > umask 022; ${MKDIR_P} "$(DESTDIR)${man1dir}" > thisdir=`pwd -P`; \ > cd ${mansrcdir}; \ > + cp ctags.1 gnuctags.1; \ This hunk also looks unrelated.