From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74413: [PATCH] Allow to store and read repository information of VCS builds Date: Tue, 19 Nov 2024 19:08:42 +0200 Message-ID: <86frnntalh.fsf@gnu.org> References: <86frnovhg8.fsf@gnu.org> <867c90vbfk.fsf@gnu.org> <861pz8uzyo.fsf@gnu.org> <86zflwtjlz.fsf@gnu.org> <86wmgztfse.fsf@gnu.org> <87ttc3td5x.fsf@thaodan.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14239"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 74413@debbugs.gnu.org, stefankangas@gmail.com To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 19 18:09:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDRj6-0003VY-Jv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Nov 2024 18:09:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDRip-0003RZ-D9; Tue, 19 Nov 2024 12:09:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDRio-0003RR-Er for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 12:09:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDRio-0000bS-6i for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 12:09:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=19k/4vtgPd580V5Z6fYZviWYwGCw7w3Q+R2qwDXK5Rs=; b=Osaa+OJs6TOWQvTGC5/ua24pGunSqb8APVmTuHm/yrKxxGQpxeN0m0lZVg0xCfsG/njfV6JXnWRDdN5geCCvSgczumfyZvjISvBJjCI5fH8ETpmD+CSobBkezEKVJn+OjmXaSsBi0o3eegHMr6QE5iMlXgHjTNj2nnz5V1J9v2hfa7sCf30XlElnPfTUEQfGPlAOJ3kC7iqs7PoD36h8G4PB8tmPEgV51p9V2aNkinXFnbtaXGSUhrqIsdEH5lZpj5kOEHwGmAkYISzXiht1aspVISxcHY7ISTCfvQgnVoqRXS3hliFdHiNpbez9OB8Ymp397sQlcU6lMOc8jc7u3g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDRin-00085b-QS for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 12:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2024 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74413-submit@debbugs.gnu.org id=B74413.173203613631083 (code B ref 74413); Tue, 19 Nov 2024 17:09:01 +0000 Original-Received: (at 74413) by debbugs.gnu.org; 19 Nov 2024 17:08:56 +0000 Original-Received: from localhost ([127.0.0.1]:43859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDRii-00085G-8c for submit@debbugs.gnu.org; Tue, 19 Nov 2024 12:08:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDRif-000852-5Q for 74413@debbugs.gnu.org; Tue, 19 Nov 2024 12:08:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDRiY-0000ZV-VH; Tue, 19 Nov 2024 12:08:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=19k/4vtgPd580V5Z6fYZviWYwGCw7w3Q+R2qwDXK5Rs=; b=Jmk2BMFRdKzDUaplrctG +rjHUvCvpkO/K91L2HrdukCUqLRrF2ts68CviV6fsVgD0gWZk6LEJf8hIa5ViHK4q/ZywF9sP1x2q SnqLhv08pQv9QxkLq4rHhkrffs12eR7W7v9PhDUZDPGbf+NR0sfnEOpujEG3zdX+ywHmcfp9/DR9Z gjBqHtpJ/TCdza9tVtk7oiKikkTafFBCGcHyoE3rR9BhU+ctu3mSGJdpqlB35kADd77+Ud8X5beYB NVlRaPl7CTDXp9aV2IzRRI+1TZdPgYo2FopXRcNJnWiLr+j+GYP0CxFTgGlMsw1/4MZOXNJt2ZKtU HVjb6GLTYnpn2w==; In-Reply-To: <87ttc3td5x.fsf@thaodan.de> (message from =?UTF-8?Q?Bj=C3=B6rn?= Bidar on Tue, 19 Nov 2024 18:13:14 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295648 Archived-At: > From: Björn Bidar > Cc: stefankangas@gmail.com, luangruo@yahoo.com, 74413@debbugs.gnu.org > Date: Tue, 19 Nov 2024 18:13:14 +0200 > > >> If the source is generated by the CI it can also store this information > >> in the build source which then can be extracted from the ci metadata to > >> the Emacs sources on the builder. > >> > >> I can be sure that Emacs was built from that revision as much as I can > >> trust the CI to use the sources I told it to use. If I can't trust one, > >> I can't trust the other. > > > > But CI builds from Git, doesn't it? If so, the Emacs it produces > > already records the revision and the branch. > > The source generator, the source service runs git but the builder > doesn't. > Because the builder doesn't have to deal with git the rebuild chain is > smaller, build dependency changes can trigger rebuilds, and the worker > doesn't have to have git installed. > > In most cases it's not required or wanted that worker have git as the > only allowed purpose would be to get access already existing metadata but > not change anything on the sources itself. > > Providing the metadata to the VCS emacs-repository-branch and > emacs-repository-version with the previously generated metadata that > belongs to the package sources removes the need for git in the build worker. Thanks, but I still don't understand the problem you are trying to solve. I guess I'm missing something very fundamental here. You are talking about "builder", "source generator", "metadata", etc., and I don't understand these terms. The last sentence seems to confirm my guess: you tage the Git revision from a repository, and then build from another directory, which can easily cause a mismatch. So this feature looks completely redundant to me, based on the little I do understand in these matters. But I will now bow out of this discussion; if Stefan (and others) think it's okay, I won't object. Thank you for your patience.