From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74700: [PATCH] Revert Dired buffer when clicking on last segment of directory name Date: Thu, 05 Dec 2024 10:41:52 +0200 Message-ID: <86frn2y10v.fsf@gnu.org> References: <874j3iodzb.fsf@gmail.com> <86ttbiy5na.fsf@gnu.org> <87zflamt6j.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74700@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 05 09:43:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJ7S8-0005rD-Fd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Dec 2024 09:43:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJ7S1-0006XP-JJ; Thu, 05 Dec 2024 03:43:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ7Rx-0006U9-FQ for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 03:43:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJ7Ru-0006Np-OR for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 03:43:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=0BuQzikeC10EpjzJgqU1VcxVM59+wgl7OtYTq9X4xkI=; b=GaGPidl+2cmIX4Rq/w3/LxftMtZs2iAGh937NjcBZfaN/AVaCf6HFBMqMPI/iZfi1tMGLORH+W1a/gtNaZoqqXRoTB9D8ZPWPgJIA9e5LruzsnTQhOIulVfA5koC7LbPDc8NKC0DxBZPOO58K5C6LwwpJfJVZfakMDl5gxfO8rtok6nw6PUUQbVYBBjxnauEwfGCD+0vQgwbFE0Bh8008/ejfcIPNu3s9V4fuvRqkG5OHDF0MSEBkT3duNIGQNtBqx1yLfTCSJBXXYFqAN7/NZ2edpa3GFi05jec4g8QZOmuebOwDB8p17QEcmMGxN9OZoz1fi8fTLRLwc1bnT2Wpg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJ7Ru-0008Lm-FL for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 03:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2024 08:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74700 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74700-submit@debbugs.gnu.org id=B74700.173338814832052 (code B ref 74700); Thu, 05 Dec 2024 08:43:02 +0000 Original-Received: (at 74700) by debbugs.gnu.org; 5 Dec 2024 08:42:28 +0000 Original-Received: from localhost ([127.0.0.1]:38163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ7RL-0008Kt-Re for submit@debbugs.gnu.org; Thu, 05 Dec 2024 03:42:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ7RK-0008Kd-Nd for 74700@debbugs.gnu.org; Thu, 05 Dec 2024 03:42:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ7RF-0005Q3-ED; Thu, 05 Dec 2024 03:42:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0BuQzikeC10EpjzJgqU1VcxVM59+wgl7OtYTq9X4xkI=; b=InGZDM1+B3oz nY3GvpGCy3Ta9SnxeooiB3rk9rSnJyt5UFWb/stXk3s1YfTnJ2vOm+yyq1VtP4M9R2TYk4vLFHZ7J Bkswfj2/eED7nvzG4YP2+Xsqn8DRlMFJ01Gr7kIGh7sXk16g5YItIU8Mwy5L/g64RZSrSHWP1774S lcZxuzysWtSvsSnxl/488tim/hpLNlnPMpBVt1JrS4fRRPv3jwgPz7VXXLeEnJLQZkA/zV3oWUILR IOwKG1h5KjFnrkyC4O0HhpB/Bu1wLPbZRtCoI4+ANuuPhQ2PWizx2Mntra/uIVgS56SAY3h4zbL5b TbbnUeJxYwg1OJcGbSSxZA==; In-Reply-To: <87zflamt6j.fsf@gmail.com> (message from Visuwesh on Thu, 05 Dec 2024 13:56:44 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296458 Archived-At: > From: Visuwesh > Cc: 74700@debbugs.gnu.org > Date: Thu, 05 Dec 2024 13:56:44 +0530 > > >> + (when (search-forward ":" bound t) > >> + (add-text-properties > >> + segment-start (1- (point)) > >> + `( mouse-face highlight > > ^^ > > We don't leave whitespace after the opening parenthesis. > > I removed the whitespace. But isn't that way to make lists such as > > ( 1 > 2 > 3) > > aligned without manual intervention? Typing something like (setq foo (1 2 3) aligns the members for me. So I don't think I understand what you are saying here. > >> + keymap ,(define-keymap > >> + "" #'revert-buffer > >> + "" 'follow-link > >> + "RET" #'revert-buffer)))))))) > > > > Should we perhaps call dired-revert directly? > > revert-buffer-function is set to dired-revert by dired. If someone has > changed it, for some reason, using revert-buffer would heed their > customisation. So I've left it as revert-buffer. That's exactly what I wonder: should we call whatever customized value of revert-buffer-function? It could be something completely different, not a function that refreshes the directory listing. What do people think about this?