From: Eli Zaretskii <eliz@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: 74700@debbugs.gnu.org
Subject: bug#74700: [PATCH] Revert Dired buffer when clicking on last segment of directory name
Date: Thu, 05 Dec 2024 10:41:52 +0200 [thread overview]
Message-ID: <86frn2y10v.fsf@gnu.org> (raw)
In-Reply-To: <87zflamt6j.fsf@gmail.com> (message from Visuwesh on Thu, 05 Dec 2024 13:56:44 +0530)
> From: Visuwesh <visuweshm@gmail.com>
> Cc: 74700@debbugs.gnu.org
> Date: Thu, 05 Dec 2024 13:56:44 +0530
>
> >> + (when (search-forward ":" bound t)
> >> + (add-text-properties
> >> + segment-start (1- (point))
> >> + `( mouse-face highlight
> > ^^
> > We don't leave whitespace after the opening parenthesis.
>
> I removed the whitespace. But isn't that way to make lists such as
>
> ( 1
> 2
> 3)
>
> aligned without manual intervention?
Typing something like
(setq foo (1
2
3)
aligns the members for me. So I don't think I understand what you are
saying here.
> >> + keymap ,(define-keymap
> >> + "<mouse-2>" #'revert-buffer
> >> + "<follow-link>" 'follow-link
> >> + "RET" #'revert-buffer))))))))
> >
> > Should we perhaps call dired-revert directly?
>
> revert-buffer-function is set to dired-revert by dired. If someone has
> changed it, for some reason, using revert-buffer would heed their
> customisation. So I've left it as revert-buffer.
That's exactly what I wonder: should we call whatever customized value
of revert-buffer-function? It could be something completely
different, not a function that refreshes the directory listing.
What do people think about this?
next prev parent reply other threads:[~2024-12-05 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 6:12 bug#74700: [PATCH] Revert Dired buffer when clicking on last segment of directory name Visuwesh
2024-12-05 7:02 ` Eli Zaretskii
2024-12-05 8:26 ` Visuwesh
2024-12-05 8:41 ` Eli Zaretskii [this message]
2024-12-05 9:02 ` Visuwesh
2024-12-05 9:24 ` Eli Zaretskii
2024-12-05 10:42 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-05 17:56 ` Juri Linkov
2024-12-12 10:31 ` Eli Zaretskii
2024-12-23 21:31 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-24 3:22 ` Visuwesh
2024-12-24 23:39 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-25 3:43 ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-25 4:47 ` Visuwesh
2024-12-26 8:56 ` Eli Zaretskii
2024-12-26 11:51 ` Visuwesh
2024-12-26 12:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86frn2y10v.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74700@debbugs.gnu.org \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).