From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#32463: 27.0.50; (logior -1) => 4611686018427387903 Date: Wed, 22 Aug 2018 09:39:50 +0100 Message-ID: <86efeqvlpl.fsf@gmail.com> References: <5230a57b-5896-606d-f157-2e547710b6e8@cs.ucla.edu> <66c3b06d-bf67-8f61-4b13-1debf0668010@cs.ucla.edu> <34ab2db1-29b5-1121-d269-4407190e255d@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1534927162 17879 195.159.176.226 (22 Aug 2018 08:39:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Aug 2018 08:39:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: 32463@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 22 10:39:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsOfe-0004Wm-1L for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Aug 2018 10:39:18 +0200 Original-Received: from localhost ([::1]:57646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsOhi-0003z0-Id for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Aug 2018 04:41:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsOhV-0003wL-CY for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 04:41:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsOhM-0002os-0q for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 04:41:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsOhK-0002o3-6F for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 04:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fsOhK-00010N-1S for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 04:41:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Aug 2018 08:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32463 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15349272253811 (code B ref -1); Wed, 22 Aug 2018 08:41:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Aug 2018 08:40:25 +0000 Original-Received: from localhost ([127.0.0.1]:57232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsOgj-0000zO-Jy for submit@debbugs.gnu.org; Wed, 22 Aug 2018 04:40:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsOgi-0000z7-EM for submit@debbugs.gnu.org; Wed, 22 Aug 2018 04:40:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsOgZ-0002G3-R1 for submit@debbugs.gnu.org; Wed, 22 Aug 2018 04:40:18 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58390) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fsOgV-0002DV-IW for submit@debbugs.gnu.org; Wed, 22 Aug 2018 04:40:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsOgU-0003CC-Hq for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 04:40:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsOgN-000297-4T for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 04:40:06 -0400 Original-Received: from [195.159.176.226] (port=48538 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsOgM-00027m-TK for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 04:40:03 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fsOeD-0002p3-DF for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 10:37:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:3vVmvKis6itI0YNVS7tNm2by9NI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149658 Archived-At: On Tue 21 Aug 2018, Paul Eggert wrote: >>>> d) Extend Fceiling, Ffloor, Fround and Ftruncate to support bignums by >>>>    updating rounding_driver. >> >> I worked on these and installed patches to master that should do (a), (b), >> and (c). For (d) I wrote the attached patch, and plan to test it a bit more >> before installing, as it's the hairiest. > > It took me longer to write the test cases than the code, but the tests did > find bugs so it was worth it. I installed the attached. Thanks for all of your recent work on bignum issues, which has siginificantly improved the bignum implementation. > While we're on the subject I moved the definition of 'bignump' and 'fixnump' > from C to Lisp, since they are easily implementable in Lisp and don't seem to > be performance relevant. Hope you don't mind too much that I would rather > minimize the low-level details that the C code exports. I agree that performance is not an issue. However implementing these in lisp assumes that bignums never represent values in fixnum range, rather than checking that. We need some checks at the C level to ensure that this property always holds. AndyM