From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51451: image-transform-original has a misleading name Date: Wed, 03 Nov 2021 20:48:29 +0200 Organization: LINKOV.NET Message-ID: <86ee7xvzwi.fsf@mail.linkov.net> References: <87ilxdnsbu.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14907"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 51451@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 03 19:50:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miLKq-0003i2-VG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 19:50:08 +0100 Original-Received: from localhost ([::1]:50318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miLKp-0007Ea-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 14:50:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miLKk-0007ES-8m for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 14:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miLKk-0001bs-0O for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 14:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miLKj-0004F7-SW for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 14:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Nov 2021 18:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51451 X-GNU-PR-Package: emacs Original-Received: via spool by 51451-submit@debbugs.gnu.org id=B51451.163596537016263 (code B ref 51451); Wed, 03 Nov 2021 18:50:01 +0000 Original-Received: (at 51451) by debbugs.gnu.org; 3 Nov 2021 18:49:30 +0000 Original-Received: from localhost ([127.0.0.1]:41245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miLKE-0004EB-EL for submit@debbugs.gnu.org; Wed, 03 Nov 2021 14:49:30 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miLKC-0004Dy-Ux for 51451@debbugs.gnu.org; Wed, 03 Nov 2021 14:49:29 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5A3B3FF80F; Wed, 3 Nov 2021 18:49:19 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Sun, 31 Oct 2021 13:24:21 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218892 Archived-At: >> image-transform-* commands are modifying the values of >> image-transform-* variables. >> Would you propose to rename variables as well? > > I didn't think about that, as the commands are what the user will see. > Maybe we should. Do you think it would be a good idea? At least, currently there is consistency in naming of image-transform-* functions and variables. Whether selecting such a prefix was a good choice is another question. But if you see a problem only in the name of image-transform-original, then it could be renamed to image-transform-set-original or maybe better to image-transform-reset-to-original, i.e. to something more descriptive, while keeping the existing name prefix. PS: renaming to image-transform-reset-to-original will also require renaming image-transform-reset to image-transform-reset-to-initial.