From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Wed, 15 Dec 2021 10:57:56 +0200 Organization: LINKOV.NET Message-ID: <86ee6egs8b.fsf@mail.linkov.net> References: <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <723c8965-31be-b636-beee-478fb77423ec@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6578"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 15 10:08:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxQGl-0001Ww-Nw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Dec 2021 10:08:15 +0100 Original-Received: from localhost ([::1]:45180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxQGk-0000HD-Ld for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Dec 2021 04:08:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxQGd-0000GU-RM for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 04:08:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxQGY-0006NQ-Qh for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 04:08:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxQGY-0006wp-JP for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 04:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 09:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163955925126649 (code B ref 52293); Wed, 15 Dec 2021 09:08:02 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 15 Dec 2021 09:07:31 +0000 Original-Received: from localhost ([127.0.0.1]:60214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxQG2-0006vl-Rm for submit@debbugs.gnu.org; Wed, 15 Dec 2021 04:07:31 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:40683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxQG1-0006vR-KX for 52293@debbugs.gnu.org; Wed, 15 Dec 2021 04:07:29 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id BC4D6E0018; Wed, 15 Dec 2021 09:07:22 +0000 (UTC) In-Reply-To: <723c8965-31be-b636-beee-478fb77423ec@gmail.com> (Jim Porter's message of "Tue, 14 Dec 2021 16:17:39 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222414 Archived-At: >> Thanks. The current question was raised by Drew who worried that >> sometimes authors might want to leave two adjacent separators >> for an empty submenu. But you answered this question that it can be >> addressed by using a special form of a separator with a menu-item. >> So I see no more problems here. > > For simplicity, I'll focus on *just* the issue described in the original > post to this bug (i.e. improving how we detect consecutive separators so we > can de-duplicate them more reliably). Then I'll send a message to > emacs-devel to gauge interest in supporting de-duplication in other menus. > > If there's interest, it would probably make sense to have the > de-duplication be opt-in so that we avoid any surprising behavior in other > menus. However, if people don't think de-duplication of separators would be > useful in other menus, then we can just keep the logic we have now (along > with the bug fix mentioned above). > > Does that sound reasonable? I'm not sure if de-duplication is needed for other menus. Currently de-duplication is used only to simplify creation of context menus. But there is no indication that someone needed this for other menus. Otherwise, they would report duplicate separators in other menus as a bug.