unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 52385@debbugs.gnu.org
Subject: bug#52385: 29.0.50; Doc-View can't view separate pages in separate windows
Date: Thu, 16 Dec 2021 19:04:12 +0200	[thread overview]
Message-ID: <86ee6c5upv.fsf@mail.linkov.net> (raw)
In-Reply-To: <86wnkbnfnp.fsf@mail.linkov.net> (Juri Linkov's message of "Sat,  11 Dec 2021 20:46:18 +0200")

>>     % emacs -Q some/multi-page.pdf
>>     C-x 2
>>     n n
>>
>> You'll see that the `n` changes the page in both windows.
>> This was not the case in Emacs<29 where this could be used to view
>> different pages of the same PDF in the exact same way we can view
>> different "pages" of a text buffer when displayed in several windows.
>
> It seems window-configuration-change-hook is not called
> after splitting the window with C-x 2, and thus
> image-mode-reapply-winprops is not called from this hook.

Actually, window-configuration-change-hook is called correctly.

But the regression is in overlay window priorities:
when two overlays with 'window' properties are added
over the same region, then in 27.2 the overlay where
the overlay window matches the selected window is preferred
over the overlay with another window.  But in 28.0.90
the first overlay always wins.

Here is the shortest test case:

  (let ((o1 (make-overlay (point-min) (point-max) nil t))
        (o2 (make-overlay (point-min) (point-max) nil t)))
    (overlay-put o1 'window (selected-window))
    (overlay-put o1 'display '(image :type xpm :file "left-arrow.xpm"))
    (select-window (split-window))
    (overlay-put o2 'window (selected-window))
    (overlay-put o2 'display '(image :type xpm :file "right-arrow.xpm")))

In 27.2 it displays different images in different windows.  But
in 28.0.90 only one images is displayed in both windows.





  reply	other threads:[~2021-12-16 17:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09  4:20 bug#52385: 29.0.50; Doc-View can't view separate pages in separate windows Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-10 11:55 ` Lars Ingebrigtsen
2021-12-10 15:05   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-11  3:23     ` Lars Ingebrigtsen
2021-12-11 18:46 ` Juri Linkov
2021-12-16 17:04   ` Juri Linkov [this message]
2021-12-16 17:44     ` Eli Zaretskii
2021-12-16 19:33       ` Juri Linkov
2021-12-16 20:09         ` Eli Zaretskii
2021-12-17  8:29           ` Juri Linkov
2021-12-17 12:08             ` Eli Zaretskii
2021-12-18 17:18               ` Juri Linkov
2021-12-18  9:11     ` Eli Zaretskii
2021-12-19 10:37       ` Lars Ingebrigtsen
2021-12-19 13:49         ` Eli Zaretskii
2021-12-19 13:54           ` Lars Ingebrigtsen
2021-12-19 14:09             ` Eli Zaretskii
2021-12-19 17:12               ` Juri Linkov
2021-12-19 17:31                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ee6c5upv.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=52385@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).