From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Wed, 16 Feb 2022 21:20:33 +0200 Organization: LINKOV.NET Message-ID: <86ee42wrcu.fsf@mail.linkov.net> References: <87lf1sw6ji.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> <871r1zm7ji.fsf@gmail.com> <87wnjrkrwd.fsf@gmail.com> <86ilv8pnf3.fsf@mail.linkov.net> <87k0fouzxs.fsf@gmail.com> <86sftumahu.fsf@mail.linkov.net> <87pmouw9qr.fsf@gmail.com> <87a6fuvzj9.fsf@gmail.com> <86bkzli245.fsf@mail.linkov.net> <875yptas9m.fsf@gnus.org> <86y22gypxn.fsf@mail.linkov.net> <871r0517jf.fsf@gmail.com> <87sfslyvya.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36796"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 51809@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 16 20:22:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKPsq-0009S3-2a for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Feb 2022 20:22:36 +0100 Original-Received: from localhost ([::1]:51164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKPso-0001DB-Iz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Feb 2022 14:22:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKPsb-0001Ao-EM for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:22:21 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKPsI-0001if-4t for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:22:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKPsI-00072N-1i for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Feb 2022 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.164503929827013 (code B ref 51809); Wed, 16 Feb 2022 19:22:02 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 16 Feb 2022 19:21:38 +0000 Original-Received: from localhost ([127.0.0.1]:49498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKPru-00071a-16 for submit@debbugs.gnu.org; Wed, 16 Feb 2022 14:21:38 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:58125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKPrs-00071G-D7; Wed, 16 Feb 2022 14:21:37 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id BA1BD1C0002; Wed, 16 Feb 2022 19:21:28 +0000 (UTC) In-Reply-To: <87sfslyvya.fsf@gmail.com> (Matthias Meulien's message of "Mon, 14 Feb 2022 22:33:49 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227055 Archived-At: close 51809 29.0.50 thanks >> My first impression is that setting `outline-level' to >> `diff--outline-level' inconditionnaly should work but since I don't >> understand why `diff-outline-regex' hasn't been defined in terms of >> `diff-file-header-re' and `diff-hunk-header-re' I guess I am missing >> some subtleties. >> >> (Note that there's another minor bug when `diff-buffer-type` isn't equal >> to 'git: `diff--font-lock-prettify` should be a no-op since the regexp >> written there match only Git generated diffs, confirmed by the FIXME >> string "This has only been tested with Git's diff output." written in >> the implementation). > > Here's the corresponding patch: Thanks for the quick fix! I confirm that it works even when `diff-buffer-type' is nil. So now your patch is pushed to master, and this request is closed.