From: Eli Zaretskii <eliz@gnu.org>
To: yantar92@posteo.net, thamer.mahmoud@gmail.com
Cc: 68446@debbugs.gnu.org
Subject: bug#68446: 29.1.90; Bidi right-to-left paragraphs missing text in Org mode
Date: Sun, 04 Feb 2024 11:51:11 +0200 [thread overview]
Message-ID: <86edds36cw.fsf@gnu.org> (raw)
In-Reply-To: <83y1csdkrg.fsf@gnu.org> (message from Eli Zaretskii on Sun, 14 Jan 2024 16:58:43 +0200)
> Cc: 68446@debbugs.gnu.org, thamer.mahmoud@gmail.com
> Date: Sun, 14 Jan 2024 16:58:43 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Ihor Radchenko <yantar92@posteo.net>
> > Cc: thamer.mahmoud@gmail.com, 68446@debbugs.gnu.org
> > Date: Sun, 14 Jan 2024 14:41:21 +0000
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > >> May you please elaborate? I do not see anything unexpected in the text
> > >> properties that Org mode applies to the link and the letter "a".
> > >
> > > ...
> > > If you describe in enough details how the [[link]] thing is handled by
> > > Org, maybe I could elaborate more than the general observations and
> > > questions above.
>
> Actually, I think I see the reason, and the problem is indeed in the
> display code's logic in this case.
There was an algorithmic flaw in handling invisible property when the
invisible text starts inside embedding level above the base paragraph
level: the code failed to account for the "backward" iteration which
is part of the bidi reordering, and instead always looked forward for
the first visible position.
> > Let's simplify the reproducer, getting rid of Org mode:
> >
> > (let ((str (concat "a " (propertize "[" 'invisible t) "b" (propertize "]" 'invisible t))))
> > (with-temp-buffer
> > (display-buffer (current-buffer))
> > (insert str)
> > (read-char "'a b' is visible. Press any key.")
> > (setq bidi-paragraph-direction 'right-to-left)
> > (read-char "'a b' is invisible. Press any key.")))
> >
> > Is this the above expected?
>
> No.
Should be fixed now on the master branch.
next prev parent reply other threads:[~2024-02-04 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 10:21 bug#68446: 29.1.90; Bidi right-to-left paragraphs missing text in Org mode Thamer Mahmoud
2024-01-14 11:24 ` Eli Zaretskii
2024-01-14 12:11 ` Ihor Radchenko
2024-01-14 13:00 ` Eli Zaretskii
2024-01-14 14:41 ` Ihor Radchenko
2024-01-14 14:58 ` Eli Zaretskii
2024-02-04 9:51 ` Eli Zaretskii [this message]
2024-02-04 13:10 ` Ihor Radchenko
2024-02-04 13:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86edds36cw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68446@debbugs.gnu.org \
--cc=thamer.mahmoud@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).