From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69832: 30.0.50; Should `subr-primitive-p` apply to special-forms? Date: Sat, 16 Mar 2024 22:17:25 +0200 Message-ID: <86edca53u2.fsf@gnu.org> References: <86il1m55bk.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30143"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69832@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 16 21:18:50 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlaUU-0007cF-9n for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Mar 2024 21:18:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlaU7-0003TK-RW; Sat, 16 Mar 2024 16:18:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlaU5-0003RT-GE for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 16:18:25 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlaU5-0007fY-7w for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 16:18:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rlaUg-0006Wg-9M for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 16:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Mar 2024 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69832 X-GNU-PR-Package: emacs Original-Received: via spool by 69832-submit@debbugs.gnu.org id=B69832.171062032825063 (code B ref 69832); Sat, 16 Mar 2024 20:19:02 +0000 Original-Received: (at 69832) by debbugs.gnu.org; 16 Mar 2024 20:18:48 +0000 Original-Received: from localhost ([127.0.0.1]:56549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlaUS-0006WA-4z for submit@debbugs.gnu.org; Sat, 16 Mar 2024 16:18:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlaUQ-0006Vt-5y for 69832@debbugs.gnu.org; Sat, 16 Mar 2024 16:18:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlaTj-0007dE-4L; Sat, 16 Mar 2024 16:18:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KvHaNEf3FC+oDfNepL2SdRjagX4YYeAxCOSLdDi2EVs=; b=ck5zFy9cf8hK Aeq3p0zoIAbAOsiH5YHgywoKoHG/1onk6i/fIa0JM08MlUDCyhxjzuLUksMaeAEYq/EVDn0HN6Wns rCFt1Agp+vOatIgKbwPVlzqMpZJMMv+z9jK5iI/nqmHOmHMd10U76QFHT+eqyBv6ZUKxJ/dxBXpR1 pOjZ0PXi4ekQpjqcEwi0oXj+TULrJuUFZNIke13/M02xcmbjU5A+GuUAIDEc8G/I7MVJ2aC9ptH7d yEupffNwsZrepdlh686rmvQJnVPgojnTdWVxThDcVxBpD0eT+LBMYJO/U9Bo0Dkk6tqzZmLl7sLkh xAsGmtdt4BIeXPF/tvNHiA==; In-Reply-To: (message from Stefan Monnier on Sat, 16 Mar 2024 15:58:09 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281739 Archived-At: > From: Stefan Monnier > Cc: 69832@debbugs.gnu.org > Date: Sat, 16 Mar 2024 15:58:09 -0400 > > > Why take the path of a breaking change instead of the non-breaking > > alternative? > > - It can be considered as a bug fix (to make the code match its doc). Or we could fix its doc string to be more accurate, and match what the code does. > - If we introduce `subr-function-p`, then `subr-primitive-p` is only > "useful" at one place any more, and we can trivially rewrite the code to > avoid it, so we could get rid of it. I don't see why we should get rid of subr-primitive-p. We can leave it alone, used in that single place where it's useful, and let 3rd party packages use it if they want. And we can then use the new function where that is needed. > - These functions are used very rarely, the majority is in core files, > and the rest is mostly used to generate human-facing descriptions > so the risk of breakage is low and the kind of breakage is likely to > have a low impact. Yes, but I've heard these famous last words one or two times too many...