unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: RwN <rwn@mailo.com>, Paul Eggert <eggert@cs.ucla.edu>
Cc: 69894@debbugs.gnu.org
Subject: bug#69894: 29.1; Icalendar export conflict with calendar iso date
Date: Thu, 28 Mar 2024 11:53:31 +0200	[thread overview]
Message-ID: <86edbuheck.fsf@gnu.org> (raw)
In-Reply-To: <86ttl3rnkm.fsf@mailo.com> (bug-gnu-emacs@gnu.org)

> Date: Tue, 19 Mar 2024 02:56:57 +0100
> From:  RwN via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> 
> Dear All,
> 
> In a diary file, with a simple entry entry "2024-03-19 10:00 Appointment", icalendar-export-file process to an error: "Could not parse date". The entry is provided by the default value of calendar-iso-date-display-form.
> 
> I solve the problem with the following patch mathchin '-' has a separator in the function icalendar--datestring-to-isodate :
> 
> diff -u --label /usr/local/share/emacs/29.1/lisp/calendar/icalendar.el.gz --label /tmp/icalendar.el /tmp/jka-commHr8dl /tmp/icalendar.el
> --- /usr/local/share/emacs/29.1/lisp/calendar/icalendar.el.gz
> +++ /tmp/icalendar.el
> @@ -894,8 +894,8 @@
>      (save-match-data
>        (cond ( ;; iso-style numeric date
>               (string-match (concat "\\s-*"
> -                                   "\\([0-9]\\{4\\}\\)[ \t/]\\s-*"
> -                                   "0?\\([1-9][0-9]?\\)[ \t/]\\s-*"
> +                                   "\\([0-9]\\{4\\}\\)[ \t/-]\\s-*"
> +                                   "0?\\([1-9][0-9]?\\)[ \t/-]\\s-*"
>                                     "0?\\([1-9][0-9]?\\)")
>                             datestring)
>               (setq year (read (substring datestring (match-beginning 1)
> 
> Diff finished.  Tue Mar 19 02:40:06 2024
> 
> Is it a correct solution to proposed? 

Paul, WDYT about the proposed change?





  reply	other threads:[~2024-03-28  9:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19  1:56 bug#69894: 29.1; Icalendar export conflict with calendar iso date RwN via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28  9:53 ` Eli Zaretskii [this message]
2024-03-28 21:26   ` Paul Eggert
2024-03-28 21:49     ` Erwan Hingant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-06  9:58       ` Eli Zaretskii
2024-04-06 10:34         ` Erwan Hingant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-08  5:50         ` Ulf Jasper via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13  7:54           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86edbuheck.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=69894@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=rwn@mailo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).