From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70385: Crash in note_fringe_highlight Date: Mon, 15 Apr 2024 16:03:27 +0300 Message-ID: <86edb6lqw0.fsf@gnu.org> References: <86h6g49cdv.fsf@mail.linkov.net> <87jzkz1kdn.fsf@yahoo.com> <86r0f6lv76.fsf@gnu.org> <8734rm25zb.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33045"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bjorn.bidar@thaodan.de, juri@linkov.net, 70385@debbugs.gnu.org, vekazanov@gmail.com To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 15 15:05:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwM1K-0008K1-SD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Apr 2024 15:05:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwM0z-0002HF-UB; Mon, 15 Apr 2024 09:04:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwM0y-0002Gr-Uh for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 09:04:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwM0y-0006Lm-Kh for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 09:04:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwM19-0005y6-UK for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 09:05:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2024 13:05:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70385 X-GNU-PR-Package: emacs Original-Received: via spool by 70385-submit@debbugs.gnu.org id=B70385.171318624722425 (code B ref 70385); Mon, 15 Apr 2024 13:05:03 +0000 Original-Received: (at 70385) by debbugs.gnu.org; 15 Apr 2024 13:04:07 +0000 Original-Received: from localhost ([127.0.0.1]:37346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwM0B-0005os-Cz for submit@debbugs.gnu.org; Mon, 15 Apr 2024 09:04:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwM06-0005mp-EH for 70385@debbugs.gnu.org; Mon, 15 Apr 2024 09:04:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwLzo-00067m-Jw; Mon, 15 Apr 2024 09:03:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=D3XCcwC5QQkOgC3VBESsuf9+lRI/QFKy+cb7aknp7o0=; b=DlNqhqmGsdvT uZuErr93FXf8H+vL2z37kHjOF6KX6poRjI+vk+za+9oWs7tPn17+5xM7XcGNDf7mfKICaoOX9+C16 8KIu65rJRQ68WhQF473hXymo2mUW3nNqaEfJ3VswNFGVOI9Gwp8d710fEpXQd/9MSLMLQOhxL4WZr nSEYX6niNT2V+Ry/lV40Rs9wr+bZquyOWYYGEtmvlQ9EddKioBavDMJpTCLaC6TtPr5JBYAHNtXRL uAdVtSAYHhXc2LtlIbgEej9Dt35MPDFDcs8Vo6NlMTSXbYTZ3Y5LEF7UKBJxqakr5mRtXYf5KlH+C jufpPLOZ5d3tQTab2gPalw==; In-Reply-To: <8734rm25zb.fsf@yahoo.com> (message from Po Lu on Mon, 15 Apr 2024 19:57:44 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283371 Archived-At: > From: Po Lu > Cc: bjorn.bidar@thaodan.de, vekazanov@gmail.com, 70385@debbugs.gnu.org, > juri@linkov.net > Date: Mon, 15 Apr 2024 19:57:44 +0800 > > Eli Zaretskii writes: > > > Any reason you didn't include w->window_end_valid in the condition, > > like we do for mouse-highlight? > > This wasn't necessary to fix the crash for me. > > > I'd like in general to have the same conditions, to avoid having > > people wonder what they miss when they read this code. > > Your wish is my command... :-) > > I suspect it might fix the Bjorn's crash also. Bjorn, please try: > > diff --git a/src/xdisp.c b/src/xdisp.c > index d984c12d1aa..51f6b1efd69 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -35771,9 +35771,10 @@ note_fringe_highlight (struct frame *f, Lisp_Object window, int x, int y, > > /* Don't access the TEXT_AREA of a row that does not display text, or > when the window is outdated. (bug#70385) */ > - if (window_outdated (w) > - || !MATRIX_ROW_DISPLAYS_TEXT_P (MATRIX_ROW (w->current_matrix, > - vpos))) > + if ((window_outdated (w) > + || !MATRIX_ROW_DISPLAYS_TEXT_P (MATRIX_ROW (w->current_matrix, > + vpos))) > + && w->window_end_valid) I think this should be if ((window_outdated (w) || !w->window_end_valid || !MATRIX_ROW_DISPLAYS_TEXT_P (MATRIX_ROW (w->current_matrix, vpos))) I'm not sure it will help, because it seems the segfault happens in the MATRIX_ROW_DISPLAYS_TEXT_P macro. So I think we are somehow dealing with w->current_matrix whose 'nrows' is too small. The mouse-highlight code detects that case in x_y_to_hpos_vpos.