From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70036: a fix that Date: Fri, 19 Apr 2024 15:13:01 +0300 Message-ID: <86edb1blf6.fsf@gnu.org> References: <4e670617-6483-4159-a5cf-27a921764c38@email.android.com> <864jbxden1.fsf@gnu.org> <86r0f1bopx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16511"; mail-complaints-to="usenet@ciao.gmane.io" Cc: felician.nemeth@gmail.com, 70036@debbugs.gnu.org, theo@thornhill.no To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 19 14:14:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxn89-00045W-RB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Apr 2024 14:14:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxn7l-0005yd-VC; Fri, 19 Apr 2024 08:13:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxn7k-0005yS-Lz for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 08:13:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxn7k-0006HM-C8 for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 08:13:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxn7y-0000iT-Cv for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 08:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Apr 2024 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.17135288122557 (code B ref 70036); Fri, 19 Apr 2024 12:14:02 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 19 Apr 2024 12:13:32 +0000 Original-Received: from localhost ([127.0.0.1]:58239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxn7T-0000fA-Im for submit@debbugs.gnu.org; Fri, 19 Apr 2024 08:13:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxn7O-0000df-Hz for 70036@debbugs.gnu.org; Fri, 19 Apr 2024 08:13:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxn73-000630-3d; Fri, 19 Apr 2024 08:13:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=pkQeJIFcQjLyv7utZJXBhtdFuaVx4w4uw4cd+LVupdg=; b=kVP/XDSxbycikMZzGoWj SUI2jcMuTaWcTga+5y8PpEOAL6K+DFjWbjFh1CXjXhJfGIjfSbjfSRn3wIEI7CsRz8TlYkv0I1L3/ V7jOPEx/kx91eScSbSuTaO7CVfCn1KzrUS1zZxbdgpkut8u6HcFvkYSk6jYqMNkt1xs2g2kK2rxPD j2ZUfy/92fLpNXGtDiFLnNUxcboNlcVEhDyCGgRqtnX/I03EJiJXZ43d8dEWB24UihSuWi5c0EK3T CcsqloEaDJ0rx3+a0qImxvsU7QBL/csg7BriyuPwgo+IwBYy2E6ezdXx/8kKXqA4PJnKOtC/cV9+l 7rXE5kcYtOcHUw==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Fri, 19 Apr 2024 13:00:54 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283680 Archived-At: > From: João Távora > Date: Fri, 19 Apr 2024 13:00:54 +0100 > Cc: theo@thornhill.no, felician.nemeth@gmail.com, 70036@debbugs.gnu.org > > On Fri, Apr 19, 2024 at 12:01 PM Eli Zaretskii wrote: > > > > Yes, that's what my latest patch does. But ideally it would be cleaner > > > (IMHO) to have a fast usable find-buffer-visiting by speeding > > > up its underlying file-truename. > > > > We did that at least to some extent in the improvements submitted by > > Ihor and now available on master. From where I stand, we now have a > > reasonably performant implementation of find-buffer-visiting; I would > > need benchmarks showing otherwise to change my mind. > > Theo's latest measurements show that -- in context -- there is a 4% > time spent in find-buffer-visiting and all of that is due to its > delegation of work to file-truename. Does that change your mind? No. The original slow-down due to find-buffer-visiting (admittedly, not in Eglot) was much worse.