From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Fri, 14 Jun 2024 15:50:43 +0300 Message-ID: <86ed8zy9gc.fsf@gnu.org> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se, stefankangas@gmail.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 14 14:54:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sI6Rd-000AJ4-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jun 2024 14:54:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sI6RQ-0005JZ-H1; Fri, 14 Jun 2024 08:54:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI6RO-0005JQ-OX for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 08:54:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sI6RO-0003OE-FP for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 08:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sI6RO-0004Qc-Ii for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 08:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jun 2024 12:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71499-submit@debbugs.gnu.org id=B71499.171836960916981 (code B ref 71499); Fri, 14 Jun 2024 12:54:02 +0000 Original-Received: (at 71499) by debbugs.gnu.org; 14 Jun 2024 12:53:29 +0000 Original-Received: from localhost ([127.0.0.1]:40132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI6Qq-0004Pp-Oc for submit@debbugs.gnu.org; Fri, 14 Jun 2024 08:53:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI6Qo-0004Pb-9C for 71499@debbugs.gnu.org; Fri, 14 Jun 2024 08:53:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI6Ob-0002je-D7; Fri, 14 Jun 2024 08:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=j8CgUaLw8oIBm75GfjfwzCiSOs1JOa781oCsilsEf+k=; b=oaUb+fY7GNTXZ8BogqVs +TzwSK6PrmIj8TpgHE68tKBJGmw1Y65arnORTq4lo1mnptRFYuaKcgtMyzPNk+gBmpsh2w6t7OLeJ vL42f6IdC6u5GimvC6d9nbEXlhZRPzzaIfJQOOpfWFDozHqQgrGlDZNCdtJVxY1BHm5j78N0dZ4qj THH4y5gcKFY86XYxcoBsVvJu7RszIcS3bSGAX3B3BzUZaiIV4QhWMgaiXnk8Kf8ofAtr27IAuiNpp ZhdqKhVE1FSAW/PAsFZ89yMiD+BRiCd7vJc5Lsr3tkIx1giiM3wNbDYGdyq1g/zQPsfP558BBmhB6 Is2ZbArlroQM3g==; In-Reply-To: <87sexfaf2i.fsf@gmail.com> (message from Robert Pluim on Fri, 14 Jun 2024 14:23:17 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287223 Archived-At: > From: Robert Pluim > Cc: Andrea Corallo , 71499@debbugs.gnu.org, > stefankangas@gmail.com, bkhl@elektrubadur.se > Date: Fri, 14 Jun 2024 14:23:17 +0200 > > >>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii said: > >> I'm as well for having the patch in, but I guess would be safer in 31 so > >> we have plenty of time to react if needed. > > Eli> OK, thanks. I will then install after the branch is cut. > > Eli> Meanwhile, Björn, I have a few comments to the patch: > > Eli> . it needs a NEWS entry announcing the new feature > Eli> . is there any reason your code to handle the missing newline is not > Eli> identical to what the implementation of require-final-newline > Eli> does? > > Iʼm going to chime in and say that, even though I highlight missing > newlines at eob, I donʼt normally set `require-final-newline' to t, > because of various reasons involving collaboration with others. So Iʼd > have to turn this off once it goes in. Maybe this feature should take a hint from require-final-newline?