From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71644: 30.0.50; Severe slowdown in larger files with markers beginning in emacs 29+ Date: Sat, 22 Jun 2024 09:57:55 +0300 Message-ID: <86ed8pjwgc.fsf@gnu.org> References: <86ed8tozub.fsf@gnu.org> <86jzijmo5a.fsf@gnu.org> <86y16ylrj9.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37688"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mitchellahren@gmail.com, 71644@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 08:59:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKuiY-0009Ze-GE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 08:59:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKuiG-0002Jv-6x; Sat, 22 Jun 2024 02:59:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKuiE-0002JU-NN for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 02:59:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKuiE-0004e7-Fx for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 02:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKuiD-0005YG-Sf for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 02:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 06:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71644 X-GNU-PR-Package: emacs Original-Received: via spool by 71644-submit@debbugs.gnu.org id=B71644.171903948921281 (code B ref 71644); Sat, 22 Jun 2024 06:59:01 +0000 Original-Received: (at 71644) by debbugs.gnu.org; 22 Jun 2024 06:58:09 +0000 Original-Received: from localhost ([127.0.0.1]:44180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKuhM-0005XB-H1 for submit@debbugs.gnu.org; Sat, 22 Jun 2024 02:58:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKuhJ-0005We-Fp for 71644@debbugs.gnu.org; Sat, 22 Jun 2024 02:58:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKuhC-0004Zq-Lt; Sat, 22 Jun 2024 02:57:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Dd3ewHRw01Kgt0A14C9OVmJsgI9Bv1UTFTDpw48S3c4=; b=mrE7JfhO0/Yl dvFfNYXBVBvShnPv8grhRW/ZhtlZ2FMIyffa3iIWZAMUZxCqLtZR51pFuRKDd+PumdMaoE3ceoBVG GlH5Gdhnp/nDpSjxoAwd4tV39YRolrF3QYqxX366DTUeLM4qLy8T6cRQhs8IEUJg/uBWlgojlVoDs e6PPoFFlRGS0AwGczaR7vfNI2fIRnTnCgrUeLnFDRf8eCL4wTWE06y8SZ1dVv0LckTHfEdw3vUkbp hMgFRInT2J8D5X3yqM97X5+l5CSjqOSRZNaqIyHnrcM2kRJH3mEBbdIliz6eo7L6jmxpL21FZCk/M ydm0ZPZKwEnsMcTshEcloQ==; In-Reply-To: (message from Stefan Monnier on Fri, 21 Jun 2024 17:06:31 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287653 Archived-At: > From: Stefan Monnier > Cc: Mitchell , 71644@debbugs.gnu.org > Date: Fri, 21 Jun 2024 17:06:31 -0400 > > > commit 8783700b23e70874c4996908bf02c010ae6f3fe1 > > Author: Stefan Monnier > > AuthorDate: Tue Aug 2 10:38:53 2022 -0400 > > Commit: Stefan Monnier > > CommitDate: Tue Aug 2 13:06:51 2022 -0400 > > > > * src/xdisp.c (redisplay_window): Use BEG rather than hard coding 1 > > > > It changed the comparison operator in two places in marker.c. > > > > Curiously, the log message doesn't even mention the change in > > marker.c, which could be a sign that this change was not intended to > > be installed. Stefan, did you intend to install it, and if so, do you > > have any comments about this bug report? > > Hmm... can't remember why/how it ended up in the above commit. > Looks like an oversight. But the change should be harmless: the > `eassert` should make sure that the comparison gives the same answer > either way (and AFAICT if/when the new comparison gives a different > answer from the old code, the old code will loop until it segfaults). Mitchell, can you try reverting that change, and see if that affects performance in your case? > > I'm a bit confused by the fact that I don't see the slowdown on my > > machine, but maybe there are other factors at work here that hide > > the regression. > > The byte<->char conversion code is affected by many unrelated moving > parts, so it can be difficult to come up with a reproducible recipe. But in this case, we did that in "emacs -Q" and with a specific test file that was posted and used. What other variables can affect this recipe? Do you see the slow response on your machine, for example, when running this recipe?