unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Björn Bidar" <bjorn.bidar@thaodan.de>
Cc: 72526@debbugs.gnu.org
Subject: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port
Date: Sat, 17 Aug 2024 13:49:50 +0300	[thread overview]
Message-ID: <86ed6n2zld.fsf@gnu.org> (raw)
In-Reply-To: <877ccftubm.fsf@> (message from Björn Bidar on Sat, 17 Aug 2024 11:41:33 +0300)

> From: Björn Bidar <bjorn.bidar@thaodan.de>
> Cc: 72526@debbugs.gnu.org
> Date: Sat, 17 Aug 2024 11:41:33 +0300
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Date: Fri, 16 Aug 2024 23:02:51 +0300
> >> From:  Björn Bidar via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >> 
> >> Could someone please review my patch?
> >
> > Sorry, I don't see any experts around to ask to do that.
> 
> Maybe the maintainer of the url package?

Whom did you have in mind?  url.el says "emacs-devel", which is
basically no one and everyone.

> > Maybe if you'd posted a more detailed description of the problem and
> > its context, someone could follow your arguments and do a meaningful
> > review.  E.g., it sounds from your description like the case of URLs
> > where it currently fails was not meant to be supported by this
> > library?  If so, perhaps an alternative is to submit to this library
> > only URLs that it supports, like after stripping the port part?
> 
> The problem is that the user in url-basic-auth when handling urls like <uri-type>://<user>@<host> isn't
> forwarded to auth-source. Further it also appends to port to the
> hostname of host which means that the host is invalid since the hostname
> includes the port number.
> 
> >From what I read when looking at url-auth.el at line 84 it does support
> this kind of case of url as it already handles the same type of url when
> it deals with <uri-type>://<user>:<password>@<host>.

So how come this code was not fixed since the day it was added to
Emacs, so long ago?





  parent reply	other threads:[~2024-08-17 10:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87bk1stevo.fsf@>
2024-08-17  6:02 ` bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port Eli Zaretskii
2024-08-17  8:41   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <877ccftubm.fsf@>
2024-08-17 10:49     ` Eli Zaretskii [this message]
2024-08-17 20:50       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]       ` <87zfpaswk4.fsf@>
2024-08-18  5:15         ` Eli Zaretskii
2024-08-18 12:30           ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]           ` <87v7zyrp29.fsf@>
2024-08-18 13:13             ` Eli Zaretskii
2024-08-19  6:54               ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]               ` <87zfp9q9ym.fsf@>
2024-08-24  8:59                 ` Eli Zaretskii
2024-08-24 11:59                   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]                   ` <87y14mb07y.fsf@>
2024-08-24 12:51                     ` Eli Zaretskii
2024-08-26  6:05                       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]                       ` <87h6b7byzb.fsf@>
2024-08-26 11:14                         ` Eli Zaretskii
     [not found] <87r0azawml.fsf@>
2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08 14:59 Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ed6n2zld.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72526@debbugs.gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).