From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73524: 29.4; bug-reference-mode matches regexp case-insensitively Date: Sat, 28 Sep 2024 20:52:46 +0300 Message-ID: <86ed5364y9.fsf@gnu.org> References: <86y13c6ukh.fsf@gnu.org> <87v7yfkaq7.fsf@gnu.org> <86ikuf68rp.fsf@gnu.org> <87y13bhfg3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9907"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73524@debbugs.gnu.org, tsdh@gnu.org To: Ulrich Mueller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 28 19:53:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1subda-0002JN-KS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Sep 2024 19:53:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1subdU-0006WQ-0b; Sat, 28 Sep 2024 13:53:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1subdQ-0006HE-5y for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2024 13:53:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1subdM-0001OQ-Tf for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2024 13:53:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=3bXeP1PRCzWjLfRtv3GjjqHF2aZ6sISKYOD9DmkRu/I=; b=ACl+ay49PpVGZuAzdz52DRZ1w/fO6Glu9BLcxQSXjr+/iugVAxPz1drZuAqS/Mw8lE168PyP8yY5KmuNI6PF9bV9aS3bOrfIERSJjOKtiaEm757FTuQBljUukVJcKBgejGJW6myjFgUrflX6I6S+dV9J4QmSGoTzHyMbLJ2EN4AdxvNOA/S5235aUC2WH0Jz2S2XbQVQcploxlaamajqy5kGRWSLw7UtyDzFlQWUUV4abusdWp2sRKT7yiG7fmML3il/4AtUFMF1Qz7gdq6/Rk1RB6nm908QA4GsPivI1JWZaNBYzPN/J7QmjQVrWatOxmIIl0oikK8JeiNxUGptOQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1subdr-0008G8-12 for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2024 13:54:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Sep 2024 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73524 X-GNU-PR-Package: emacs Original-Received: via spool by 73524-submit@debbugs.gnu.org id=B73524.172754601031678 (code B ref 73524); Sat, 28 Sep 2024 17:54:02 +0000 Original-Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 17:53:30 +0000 Original-Received: from localhost ([127.0.0.1]:38616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1subdK-0008Es-2m for submit@debbugs.gnu.org; Sat, 28 Sep 2024 13:53:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:32894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1subdH-0008Ef-QK for 73524@debbugs.gnu.org; Sat, 28 Sep 2024 13:53:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1subcg-0001K2-Jo; Sat, 28 Sep 2024 13:52:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3bXeP1PRCzWjLfRtv3GjjqHF2aZ6sISKYOD9DmkRu/I=; b=jdVKHnsAIkR2 FcTHsuD/ofq/sRPbtai1N651BFSkdRx7KY8HkphSXw8tyd+vLrfkBPTSlWqiz1oMRz+sqNZZGAAqH FSTWOafjCmhuDG+DTU4irLr8Ac6nxj1PFFcjHQ2Sn2Iscugr3HjeXdS8KleAxjFkcy9TU1fZ7VTNZ RqmYkntds46xfBNwoYy2mF0ZgqjzldcI7XTJgAIDwlZY0FdiETYy5nXac4cIEMt1c+oDmhY1fJzIM P+33+RiXy9ThnnPr1XVBUzEf+K1ek4BmpkzWoaon7F5NUpPj2TPnMOr0X8z6Rs/IugdpMsMV7D5j0 3TSvW8n2jwR4XhS+A67QFg==; In-Reply-To: (message from Ulrich Mueller on Sat, 28 Sep 2024 19:25:19 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292596 Archived-At: > From: Ulrich Mueller > Cc: Eli Zaretskii , 73524@debbugs.gnu.org > Date: Sat, 28 Sep 2024 19:25:19 +0200 > > >>>>> On Sat, 28 Sep 2024, Tassilo Horn wrote: > > > Eli Zaretskii writes: > >> > >> If we want to always match case-insensitively in bug-reference, then > >> we could bind case-fold-search to t in bug-reference-fontify, no? > > > Sure, if we are convinced that there's really no scenario where bug > > references are case-sensitive. I would think this is very uncommon but > > not impossible. > > What about the other examples in the default, i.e. "RFE" and "PR"? > I'm not completely convinced that matching their lower-case form would > be a good thing. I see in binutils-gdb repository most "PR" are in upper-case, but all. Example: commit ecb915b4de7569027ad78bd3e24873bb92cb8e32 Author: Nelson Chu AuthorDate: Mon Sep 12 09:26:52 2022 +0800 Commit: Nelson Chu CommitDate: Mon Sep 12 11:31:41 2022 +0800 RISC-V: PR28509, the default visibility symbol cannot be referenced by R_RIS When generating the shared object, the default visibility symbols may bind externally, which means they will be exported to the dynamic symbol table, and are preemptible by default. These symbols cannot be referenced by the non-pic R_RISCV_JAL and R_RISCV_RVC_JUMP. However, consider that linker may relax the R_RISCV_CALL relocations to R_RISCV_JAL or R_RISCV_RVC_JUMP, if these relocations are relocated to the plt entries, then we won't report error for them. Perhaps we also need the similar checks for the R_RISCV_BRANCH and R_RISCV_RVC_BRANCH relocations. After applying this patch, and revert the following glibc patch, riscv: Fix incorrect jal with HIDDEN_JUMPTARGET https://sourceware.org/git/?p=glibc.git;a=commit;h=68389203832ab39dd0dbaabbc I get the expected errors as follows, ld: relocation R_RISCV_RVC_JUMP against `__sigsetjmp' which may bind externa ld: relocation R_RISCV_JAL against `exit' which may bind externally can not Besides, we also have similar changes for libgcc, RISC-V: jal cannot refer to a default visibility symbol for shared object https://github.com/gcc-mirror/gcc/commit/45116f342057b7facecd3d05c2091ce3a77 bfd/ pr 28509 * elfnn-riscv.c (riscv_elf_relocate_section): Report errors when makeing a shard object, and the referenced symbols of R_RISCV_JAL relocations are default visibility. Besides, we should handle most of the cases here, so don't need the unresolvable check later for R_RISCV_JAL and R_RISCV_RVC_JUMP. ld/ pr 28509 * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated. * testsuite/ld-riscv-elf/lib-nopic-01a.s: Removed. * testsuite/ld-riscv-elf/lib-nopic-01b.d: Likewise. * testsuite/ld-riscv-elf/lib-nopic-01b.s: Likewise. * testsuite/ld-riscv-elf/shared-lib-nopic-01.d: New testcase. * testsuite/ld-riscv-elf/shared-lib-nopic-01.s: Likewise. * testsuite/ld-riscv-elf/shared-lib-nopic-02.d: Likewise. * testsuite/ld-riscv-elf/shared-lib-nopic-02.s: Likewise. * testsuite/ld-riscv-elf/shared-lib-nopic-03.d: Likewise. * testsuite/ld-riscv-elf/shared-lib-nopic-03.s: Likewise. * testsuite/ld-riscv-elf/shared-lib-nopic-04.d: Likewise. * testsuite/ld-riscv-elf/shared-lib-nopic-04.s: Likewise. Not sure about RFE (where is that used?)