From: Eli Zaretskii <eliz@gnu.org>
To: rpluim@gmail.com
Cc: 73764@debbugs.gnu.org, schwab@linux-m68k.org,
monnier@iro.umontreal.ca, eduardoochs@gmail.com
Subject: bug#73764: format-kbd-macro returns a key name that keymap-lookup doesn't recognize
Date: Mon, 14 Oct 2024 19:25:33 +0300 [thread overview]
Message-ID: <86ed4islc2.fsf@gnu.org> (raw)
In-Reply-To: <86froysmrw.fsf@gnu.org> (message from Eli Zaretskii on Mon, 14 Oct 2024 18:54:27 +0300)
> Cc: 73764@debbugs.gnu.org, schwab@linux-m68k.org, monnier@iro.umontreal.ca,
> eduardoochs@gmail.com
> Date: Mon, 14 Oct 2024 18:54:27 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Robert Pluim <rpluim@gmail.com>
> > Cc: Andreas Schwab <schwab@linux-m68k.org>, 73764@debbugs.gnu.org,
> > monnier@iro.umontreal.ca, eduardoochs@gmail.com
> > Date: Mon, 14 Oct 2024 17:06:05 +0200
> >
> > So if format-kbd-macro generates something with 'C-' in the "wrong"
> > place, whatʼs to stop us re-ordering the modifiers as a
> > post-processing step (inside `format-kbd-macro')?
>
> If that's the only case where we put C- in the wrong place, then
> nothing stops us. Is it?
In any case, there's the more general issue at hand here:
keymap--check is (at least in this case) unnecessarily restrictive:
where key-parse will gladly accept and correctly process a key whose
modifiers are in any order, keymap--check insist on the canonical
order. I'm not sure I like this, at least in non-interactive
functions.
next prev parent reply other threads:[~2024-10-14 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 4:46 bug#73764: format-kbd-macro returns a key name that keymap-lookup doesn't recognize Eduardo Ochs
2024-10-12 9:18 ` Eli Zaretskii
2024-10-12 13:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 14:36 ` Eli Zaretskii
2024-10-12 14:51 ` Andreas Schwab
2024-10-12 15:18 ` Eli Zaretskii
2024-10-14 15:06 ` Robert Pluim
2024-10-14 15:54 ` Eli Zaretskii
2024-10-14 16:25 ` Eli Zaretskii [this message]
2024-10-14 21:48 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ed4islc2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73764@debbugs.gnu.org \
--cc=eduardoochs@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=rpluim@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).