From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73722: 30.0.91; error calling eshell/clear with no argument Date: Wed, 16 Oct 2024 08:17:44 +0300 Message-ID: <86ed4gr5hj.fsf@gnu.org> References: <87v7y1p4fi.fsf@librehacker.com> <2126f0f9-388e-5717-b0af-b7e3ec90e7d9@gmail.com> <86msj5qm2g.fsf@gnu.org> <05bd5ca0-7c14-a2af-ff58-77e6725b4be7@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24131"; mail-complaints-to="usenet@ciao.gmane.io" Cc: christopher@librehacker.com, 73722@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 16 07:19:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0wR4-00062A-AJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Oct 2024 07:19:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0wQo-0005Y5-46; Wed, 16 Oct 2024 01:18:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0wQl-0005Xk-OZ for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 01:18:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0wQl-0000Uu-GH for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 01:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=rOWacMuuhSEWIWDhiR5cJuoQqns+9YPC1al/L4X7Q4c=; b=InStoP2zQEcCaWW+9amZcblZR3CyVD84EuYUelrp3MUZ+i1t+rEiXpqqpHixiF7/ndImMFXsPA+htIdYXVjgnwSy8ILUC39+Gw5261jh0A5H5swzQC6t/N0LZigdq4alkQkb9s01aj63nB1fntxGjLPrlQ0WtnySN5+hBczg9QbAtNQ8wbdFonENwnuXwYfrr8v0bN789spm9GrQqs2vSGdfkgZ5rzrgIdEExB7oEukboVXDQT5HpppppYyJR6Cuu8ssAVQgdX+Hqb/BE8eubpjGqVgiJDebn2w5puE6msWXrIuX+1qHYFhDRLinKzTkBX5VL6p1D5uQ5kkNw1ZcCA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0wR4-0003CT-Hz for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 01:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2024 05:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73722 X-GNU-PR-Package: emacs Original-Received: via spool by 73722-submit@debbugs.gnu.org id=B73722.172905589412223 (code B ref 73722); Wed, 16 Oct 2024 05:19:02 +0000 Original-Received: (at 73722) by debbugs.gnu.org; 16 Oct 2024 05:18:14 +0000 Original-Received: from localhost ([127.0.0.1]:58196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0wQI-0003B5-0n for submit@debbugs.gnu.org; Wed, 16 Oct 2024 01:18:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0wQG-0003Ap-L2 for 73722@debbugs.gnu.org; Wed, 16 Oct 2024 01:18:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0wPq-0000PQ-Lm; Wed, 16 Oct 2024 01:17:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rOWacMuuhSEWIWDhiR5cJuoQqns+9YPC1al/L4X7Q4c=; b=Quz5IUztBG5R 2Z7LQ02gR0Y3kzjt1s5nAkz2f4/S7ghsUkVcWU9A7dwh3rduvii78fA3MgFJ5AoKimhjlONahlaft OERXETLL2RA7YOGVtK623Z86S1Cq5HtuyNAvpeHiw7qhlSxmCzedgPLRmYTsILo+3vikyNnvaLiPk iCrJubK8/1+ziGdq8Oz2lDu98xXW5rjDRYsawhFISpMr0uQjbNCmMMV/ihV+1Kygt8janrBBxbM4V Z9GmbDhV7m2/Z7eVagdpuTKYHuwpj/yhMVGTXAdUd4PBekrWcQIPiQ/TEiFKP2jBIQSnUSv4/y1q2 K/4QXx52VivuGNJ9E6Oq5g==; In-Reply-To: <05bd5ca0-7c14-a2af-ff58-77e6725b4be7@gmail.com> (message from Jim Porter on Tue, 15 Oct 2024 14:31:21 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293657 Archived-At: > Date: Tue, 15 Oct 2024 14:31:21 -0700 > Cc: christopher@librehacker.com, 73722@debbugs.gnu.org > From: Jim Porter > > On 10/15/2024 11:04 AM, Eli Zaretskii wrote: > >> Eli, does this look ok for the release branch? It fixes a regression > >> from Emacs 29 and adds a pair of regression tests to prevent future > >> breakage. (If and when this merges, I'll see about a more-thorough fix > >> for the master branch too.) > > > > If the problem is with empty body of progn, why does the fix have to > > be so much less self-evident? Can you fix it by protecting against > > empty body of progn instead, so that the fix is less likely to cause > > unintended consequences? > > That's just the loudest part of the bug. Even though I've already fixed > that part on Emacs 31, things still don't work correctly there. If you > run the "clear" command in Eshell it clears the screen, but then prints > two new prompts on the same line together. However, this behavior is > pretty close to what "clear" did in Emacs 29: it prints two prompts (but > there's a newline between them). > > If I fix the empty 'progn' case, I guess that would fix the regression > (aside from the missing newline, which I'm not sure how to fix). > However, "clear" still wouldn't work correctly. > > What do you think would be better for Emacs 30? Fix "clear" so it works > properly, or just fix the new regression? (In the latter case, I can fix > it with a one-liner.) At this late stage, I prefer the latter, yes.