From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.bugs Subject: bug#71572: [PATCH] seconds-to-string-approximate Date: Sat, 22 Jun 2024 16:56:39 -0500 Message-ID: <86def446-b00d-4127-b5eb-b3fd7859e869@alphapapa.net> References: <86r0cpicwt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28542"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71572@debbugs.gnu.org, jonas@bernoul.li To: Eli Zaretskii , JD Smith , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 23:57:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sL8jT-000780-Sb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 23:57:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sL8jJ-000565-Cu; Sat, 22 Jun 2024 17:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL8jG-0004ew-Au for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 17:57:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sL8jG-0001R3-0v for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 17:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sL8jF-0005wD-TT for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 17:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 21:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71572-submit@debbugs.gnu.org id=B71572.171909340522794 (code B ref 71572); Sat, 22 Jun 2024 21:57:01 +0000 Original-Received: (at 71572) by debbugs.gnu.org; 22 Jun 2024 21:56:45 +0000 Original-Received: from localhost ([127.0.0.1]:33470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL8iy-0005va-Un for submit@debbugs.gnu.org; Sat, 22 Jun 2024 17:56:45 -0400 Original-Received: from crab.oak.relay.mailchannels.net ([23.83.215.42]:54329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL8ix-0005vQ-75 for 71572@debbugs.gnu.org; Sat, 22 Jun 2024 17:56:43 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A9EAF5C1F21; Sat, 22 Jun 2024 21:56:41 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a235.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 54B3F5C16AB; Sat, 22 Jun 2024 21:56:41 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1719093401; a=rsa-sha256; cv=none; b=VWkyaLFmFfOyTuQtUMfixVFIaFrj8GZJXlxGuYwBwxUA8VJPiFVIAHBnjAqQw+C89xefmw xP4JYM4yGEAACEOyhvkOTi5IM058S5NnJuQt/MOd9DuuQXNL1rM8hQ9d3Dv9URuGZJt+Hp QJqERbrk9vEQ04liFbvkOBMhPIgfjNzVsiJpUVcM/JXaE8HyvlBfrtYBUfJ7vAY9EJ6gDt o+yO6fPMYwrCLez7/1BKBPMEtwnVy0Nhc4jHs60WGtvtWg08edKPw1lJTaT+/Shp8xpMeI FBsjW+H88+0qlnbeqrUPi9Ci/5gr3Y/G8jv+eMH9OWHTuWJZ2pbLZnQOiMfHvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1719093401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eSKRsPT74GkfYnbCqCE8EJtI34StjHqHOT8QDV8tdLQ=; b=qSnHTQ1jF1COltz2nyYsC8YxN5p9SBO3cKZzaGD434xAVGZIdTD/R7rRyEaaK6eI3QCYIc ROgnl7tUqcEeUDGLfp/jEXstlbm+4HIe4Jme5RNLv+eiiinkCe7Y5tIm606GMTQFvDCvVs 5X9DR6otcqmB/VC+NtyDc5nccRtuOYUrhnig+y7YSGR5haGP6+EudVDk0b8HeXzF7CQ2eM 3nzOrIPaHsedRqtZFGYgvqag6Ugj8Oc1RdXbR5aXmg0NFcPVv3eNtCANLsvJTsyfjcYhjC C1IglOen4ZpaLolx9mjhzlUr3YE36pVIbn+nVDq2SrczNns2jkebVs5LJoiFhA== ARC-Authentication-Results: i=1; rspamd-79677bdb95-965kd; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Versed-Daffy: 1fa990c756dccb08_1719093401592_2373822015 X-MC-Loop-Signature: 1719093401592:1901154522 X-MC-Ingress-Time: 1719093401592 Original-Received: from pdx1-sub0-mail-a235.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.121.33.136 (trex/6.9.2); Sat, 22 Jun 2024 21:56:41 +0000 Original-Received: from [10.17.178.125] (unknown [172.98.33.7]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a235.dreamhost.com (Postfix) with ESMTPSA id 4W67NS4P5fz2D; Sat, 22 Jun 2024 14:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1719093401; bh=eSKRsPT74GkfYnbCqCE8EJtI34StjHqHOT8QDV8tdLQ=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=IR23DR+eIedIpVfkkC1O1lHIfHEIF+5qg93dEqSeakdgqNuNrCDVb8Gacto/zATxa R428snOCM7JwdehdoqbXjr/o638nohwkvJNJoRCsCRPUZAEQOLHFWD3FH6WcFsykp4 6SasfFMYYcdpI6N7gUKA3DYvbizOWlYR1Ws9n/xpK+L7sdgZ/2qwAQoJcj8EEuVfc7 ywwavyLod944dqngjp9Tn5fBP33FhgzuBu2PDrq9m7CIpW83pV+J+Dc4AmHyceFf/y 4tuRTKcPmBa30BBaA4XEk0f/OyI9mcZzc7YDmId9bLyI2hJO2w5h2tGa3SzFJY0Mdc YNNyUkXgQ7peg== Content-Language: en-US In-Reply-To: <86r0cpicwt.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287741 Archived-At: May I also recommend that the function be benchmarked, and potentially that it be profiled and optimized if needed? A function like this may be used on hundreds or even thousands of items in a single operation (e.g. formatting a long list of items into a vtable), so it's important that it not be too slow. I don't think I've seen mention of performance yet (forgive me if I missed it).