From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#18954: 24.4; vc-log Summary: header is included in the log message Date: Wed, 25 Nov 2015 04:25:11 +0200 Message-ID: <86d1uyx1bs.fsf@yandex.ru> References: <7E039918541B4C4183BFDB8F015C7430813FAC@WCL-EXCH02.wcl.local> <874mud7e8b.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1448418387 26809 80.91.229.3 (25 Nov 2015 02:26:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Nov 2015 02:26:27 +0000 (UTC) Cc: 18954@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 25 03:26:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1Pme-0002VI-QB for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2015 03:26:12 +0100 Original-Received: from localhost ([::1]:42606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Pma-0001r8-Tr for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Nov 2015 21:26:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1PmX-0001qP-Ff for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 21:26:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1PmU-00067l-6t for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 21:26:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1PmU-00067h-3J for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 21:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a1PmT-0000wf-Pj for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 21:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2015 02:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18954-submit@debbugs.gnu.org id=B18954.14484183183579 (code B ref 18954); Wed, 25 Nov 2015 02:26:01 +0000 Original-Received: (at 18954) by debbugs.gnu.org; 25 Nov 2015 02:25:18 +0000 Original-Received: from localhost ([127.0.0.1]:51938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Pll-0000vf-Qk for submit@debbugs.gnu.org; Tue, 24 Nov 2015 21:25:18 -0500 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:34308) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Plj-0000vV-A2 for 18954@debbugs.gnu.org; Tue, 24 Nov 2015 21:25:16 -0500 Original-Received: by wmvv187 with SMTP id v187so236605079wmv.1 for <18954@debbugs.gnu.org>; Tue, 24 Nov 2015 18:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=nCFiEzPwYjuOkNJ/hlygohDlWoOgoIGtMHcd7Ea/5qY=; b=WOrPDIU4Iq3FwkiJVr+7y+dm6nOnTtUZV9NRan1ng2FqN0V4gtb43zZACN3gfvUUJL 7U5vUSeY61Ul9agUCduuR63dtlmcisQE6PFkfOhzne9GUh5X/XTrwTESu2jCLRpivBbV LC5D0tHGw2YH1OEmCp+jZIYn/yr91AGMV1Hle0mppXaISLfT/KBbkoFKQ+xyXSj4dUOI EXiP7pJwelOwoxTD0yLdhB1kGIzQZsh9dwtXKCYg3G2jpj3oq0Buc7Orq5ABh2vb7cND eUDG4Z+98G6sm99/iN22BxBXMWjhcmuuWQXrhoqndIK4RtXjkMEE3VpeBhI8lXU2Ga/R FX5w== X-Received: by 10.194.78.162 with SMTP id c2mr48071934wjx.112.1448418314787; Tue, 24 Nov 2015 18:25:14 -0800 (PST) Original-Received: from axl ([185.105.175.24]) by smtp.gmail.com with ESMTPSA id u134sm1198882wmd.0.2015.11.24.18.25.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Nov 2015 18:25:13 -0800 (PST) In-Reply-To: <874mud7e8b.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 05 Nov 2014 17:24:04 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109216 Archived-At: Ivan Shmakov writes: > A quick scan through vc/*.el suggest that the Summary: header is > only recognized by vc-arch.el (which, however, doesn=E2=80=99t seem to > take care of Author:), while only vc-git.el seems to recognize > Author: (and doesn=E2=80=99t seem to care about Summary: in turn.) Too quick a scan. log-edit-extract-headers recognizes the Summary header by default, so the difference must be betwen backends that pipe their commit message through that function, and those that don't. > If so, this bug actually affects most of the VCS supported by > the Emacs VC facility, and not just Subversion. Quite a few of those, yes: RCS, SRC, SCCS and CVS must have this problem, as well as the obsolete MCVS and Arch. I'm puzzled, however, why hasn't anyone else reported this problem by now? Maybe nobody uses most of those, but what about CVS? Do its users just stay on older Emacs versions? > =E2=80=A2 Amend the log-edit-insert-message-template function to only > generate the template if /either/ explicitly requested by the > user (as in: via a yes-maybe-no variable setting, or by > running it interactively) /or/ when the headers in question > are known to be recognized by the target VCS. The easiest solution seems to be to teach all VC backends to recognize it. It would be rather hard for me to test the results, though.