From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9923: 24.0.91; `where-is' does not find recentf menu items (cmds, not files) Date: Wed, 08 Dec 2021 22:32:17 +0200 Organization: LINKOV.NET Message-ID: <86czm6rg6m.fsf@mail.linkov.net> References: <76FA3F83D086455EAA01FF0FB000FCDB@us.oracle.com> <871r6hk99k.fsf@gnus.org> <87bl5k2ug1.fsf@gnus.org> <87czpwb4gw.fsf@mail.linkov.net> <8635n753o3.fsf@mail.linkov.net> <8635n613xt.fsf@mail.linkov.net> <86fsr5zlwg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40301"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 9923@debbugs.gnu.org, Lars Ingebrigtsen To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 08 21:33:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mv3d6-000AL4-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Dec 2021 21:33:32 +0100 Original-Received: from localhost ([::1]:53612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mv3d5-0004MD-2M for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Dec 2021 15:33:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv3cc-0004Hb-SC for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2021 15:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58396) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mv3cc-0002Qk-KI for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2021 15:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mv3cc-00068c-I8 for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2021 15:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2021 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 9923-submit@debbugs.gnu.org id=B9923.163899558023572 (code B ref 9923); Wed, 08 Dec 2021 20:33:02 +0000 Original-Received: (at 9923) by debbugs.gnu.org; 8 Dec 2021 20:33:00 +0000 Original-Received: from localhost ([127.0.0.1]:41706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv3ca-000686-6p for submit@debbugs.gnu.org; Wed, 08 Dec 2021 15:33:00 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:37947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv3cY-00067n-0t for 9923@debbugs.gnu.org; Wed, 08 Dec 2021 15:32:58 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 6774E6000B; Wed, 8 Dec 2021 20:32:49 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Mon, 06 Dec 2021 14:01:45 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221951 Archived-At: >> I confirm that it prevents `where-is-internal` from calling `context-menu-map`, >> and everything else works fine, but I'm not sure how this change fits >> into the overall design of the menu bindings. Maybe, `make-sparse-keymap` >> means that `context-menu-entry` contains an empty menu initially. > > No, it's just that `where-is-internal` by-and-large doesn't run the > `:filter`s when doing its search, so instead of seeing a binding to > `ignore` it will see a binding to an empty keymap. > > As we've seen `where-is-internal` does end up running the `:filter` > sometimes, but it's only done on those few bindings that match. > > When building a menu, the `ignore` or the empty keymap won't be used at > all (their only use will be to pass them to the `:filter` function, > which ignores that argument). That's why the "binding" is currently > called `ignore`: not because we want to use the `ignore` command but as > a way to say "this is not used". I pushed this fix to master, but not sure if it should be backported to emacs-28.