From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Mon, 12 Dec 2022 19:41:52 +0200 Organization: LINKOV.NET Message-ID: <86cz8or02n.fsf@mail.linkov.net> References: <8735budxiz.fsf@gmail.com> <83a662dvgo.fsf@gnu.org> <871qqvj6qb.fsf@gmail.com> <42bb91a0-60ff-2e51-dcdc-c1e1f80e31ec@yandex.ru> <837d0lmmpi.fsf@gnu.org> <1cce089a-546e-7f13-0907-3d36452aef10@yandex.ru> <83v8o5l0wa.fsf@gnu.org> <5c1cc828-5fcd-667f-41d4-f19923b2958e@yandex.ru> <87k04li5nw.fsf@gmail.com> <864jvphx4r.fsf@mail.linkov.net> <86tu3mftm0.fsf@mail.linkov.net> <875yg0to11.fsf@gmail.com> <86zgdalj0h.fsf@mail.linkov.net> <86fsdpjasd.fsf@mail.linkov.net> <86k02zjiwj.fsf@mail.linkov.net> <864ju1lt5k.fsf@mail.linkov.net> <403e8284-e32c-f547-748e-371d26eedace@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36063"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , Augusto Stoffel , 58447@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 18:45:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4msG-0009Bu-UH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 18:45:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4mrQ-0007FB-B6; Mon, 12 Dec 2022 12:45:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4mrP-0007Dk-9T for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 12:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4mrP-0000UU-0J for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 12:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4mrO-0001Wv-SK for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 12:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.16708670835808 (code B ref 58447); Mon, 12 Dec 2022 17:45:02 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 12 Dec 2022 17:44:43 +0000 Original-Received: from localhost ([127.0.0.1]:54329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4mr5-0001Vb-EC for submit@debbugs.gnu.org; Mon, 12 Dec 2022 12:44:43 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:39079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4mr3-0001VK-T9 for 58447@debbugs.gnu.org; Mon, 12 Dec 2022 12:44:42 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B34F060009; Mon, 12 Dec 2022 17:44:34 +0000 (UTC) In-Reply-To: <403e8284-e32c-f547-748e-371d26eedace@yandex.ru> (Dmitry Gutov's message of "Sun, 11 Dec 2022 20:14:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250733 Archived-At: >>>>>> One solution would be to write a confirmation function instead of using >>>>>> the symbol 'confirm' for completing-read in project--completing-read-strict. >>>>>> Such a function could check if the filename is absolute >>>>> And exists, I suppose? >>>> I'd prefer to have separate histories: with absolute filenames for C-x >>>> C-f, >>>> and project-relative filenames for C-x p f. >>> Yeah, ok. >>> >>> I think we just postponed this improvement because we might not manage it >>> in time for the 29's release. >> Unfortunately, this makes the emacs-29 release unusable. > > Would you say the new behavior is worse than what we had before? Unfortunately, yes. It turned out that it interferes too much in normal workflows of using 'C-x p f'. I suggest to keep the history of 'C-x p f' with relative filenames intact, and add absolute filenames to 'file-name-history' that already contains absolute filenames.