unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
@ 2023-03-19 17:36 Juri Linkov
  2023-03-19 20:21 ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2023-03-19 17:36 UTC (permalink / raw)
  To: 62276

0. emacs-29 -Q
1. C-x C-f etc/images/attach.xpm RET
2. C-c C-c toggles from image to C code
3. C-c C-c toggles back from C code to image
4. C-x k RET

Everything works correctly so far.

4. M-: (require 'c-ts-mode) RET
5. C-x C-f etc/images/attach.xpm RET

It's not displayed as an image and C-c C-c does nothing.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
  2023-03-19 17:36 bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode Juri Linkov
@ 2023-03-19 20:21 ` Eli Zaretskii
  2023-03-20 18:10   ` Juri Linkov
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-03-19 20:21 UTC (permalink / raw)
  To: Juri Linkov; +Cc: 62276

> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 19 Mar 2023 19:36:30 +0200
> 
> 4. M-: (require 'c-ts-mode) RET
> 5. C-x C-f etc/images/attach.xpm RET
> 
> It's not displayed as an image and C-c C-c does nothing.

Thanks, should be fixed now on the emacs-29 branch.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
  2023-03-19 20:21 ` Eli Zaretskii
@ 2023-03-20 18:10   ` Juri Linkov
  2023-03-20 18:47     ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2023-03-20 18:10 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 62276

>> 4. M-: (require 'c-ts-mode) RET
>> 5. C-x C-f etc/images/attach.xpm RET
>>
>> It's not displayed as an image and C-c C-c does nothing.
>
> Thanks, should be fixed now on the emacs-29 branch.

Are there other modes that require such ad-hoc hacks?
Is there a problem with this pair?

     ("\\.svgz?\\'" . image-mode)
     ("\\.svgz?\\'" . xml-mode)

There is only html-ts-mode, not xml-ts-mode?





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
  2023-03-20 18:10   ` Juri Linkov
@ 2023-03-20 18:47     ` Eli Zaretskii
  2023-03-21 18:46       ` Juri Linkov
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-03-20 18:47 UTC (permalink / raw)
  To: Juri Linkov; +Cc: 62276

> From: Juri Linkov <juri@linkov.net>
> Cc: 62276@debbugs.gnu.org
> Date: Mon, 20 Mar 2023 20:10:19 +0200
> 
> >> 4. M-: (require 'c-ts-mode) RET
> >> 5. C-x C-f etc/images/attach.xpm RET
> >>
> >> It's not displayed as an image and C-c C-c does nothing.
> >
> > Thanks, should be fixed now on the emacs-29 branch.
> 
> Are there other modes that require such ad-hoc hacks?

The ad-hocery was required because files.el itself uses an ugly (and
undocumented) hack to allow visiting XPM/XBM as either a C file or an
image file.

> Is there a problem with this pair?
> 
>      ("\\.svgz?\\'" . image-mode)
>      ("\\.svgz?\\'" . xml-mode)

I don't know.  Is there?

> There is only html-ts-mode, not xml-ts-mode?

Yes, at least for now.  I don't think there's a grammar library for
XML.

Can we close this bug now?





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
  2023-03-20 18:47     ` Eli Zaretskii
@ 2023-03-21 18:46       ` Juri Linkov
  0 siblings, 0 replies; 5+ messages in thread
From: Juri Linkov @ 2023-03-21 18:46 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 62276-done

>> >> 4. M-: (require 'c-ts-mode) RET
>> >> 5. C-x C-f etc/images/attach.xpm RET
>> >>
>> >> It's not displayed as an image and C-c C-c does nothing.
>> >
>> > Thanks, should be fixed now on the emacs-29 branch.
>> 
>> Are there other modes that require such ad-hoc hacks?
>
> The ad-hocery was required because files.el itself uses an ugly (and
> undocumented) hack to allow visiting XPM/XBM as either a C file or an
> image file.
>
>> Is there a problem with this pair?
>> 
>>      ("\\.svgz?\\'" . image-mode)
>>      ("\\.svgz?\\'" . xml-mode)
>
> I don't know.  Is there?
>
>> There is only html-ts-mode, not xml-ts-mode?
>
> Yes, at least for now.  I don't think there's a grammar library for
> XML.
>
> Can we close this bug now?

It seems no more fixes are required, so now closing.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-21 18:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-19 17:36 bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode Juri Linkov
2023-03-19 20:21 ` Eli Zaretskii
2023-03-20 18:10   ` Juri Linkov
2023-03-20 18:47     ` Eli Zaretskii
2023-03-21 18:46       ` Juri Linkov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).