From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63690: 29.0.91; New vc commands missing on vc-menu Date: Wed, 24 May 2023 20:31:21 +0300 Organization: LINKOV.NET Message-ID: <86cz2pzlee.fsf@mail.linkov.net> References: <86cz2q404g.fsf@mail.linkov.net> <834jo1oeou.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34542"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 63690@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 24 19:33:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1sMY-0008mS-RX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 May 2023 19:33:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1sMM-00066N-TU; Wed, 24 May 2023 13:33:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1sMA-0005rP-Mj for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 13:33:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1sMA-0000k1-Ev for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 13:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1sMA-0000Xz-AH for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 13:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2023 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63690 X-GNU-PR-Package: emacs Original-Received: via spool by 63690-submit@debbugs.gnu.org id=B63690.16849495522062 (code B ref 63690); Wed, 24 May 2023 17:33:02 +0000 Original-Received: (at 63690) by debbugs.gnu.org; 24 May 2023 17:32:32 +0000 Original-Received: from localhost ([127.0.0.1]:45037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1sLg-0000XA-2W for submit@debbugs.gnu.org; Wed, 24 May 2023 13:32:32 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1sLd-0000Wu-0a for 63690@debbugs.gnu.org; Wed, 24 May 2023 13:32:30 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 11389E0002; Wed, 24 May 2023 17:32:21 +0000 (UTC) In-Reply-To: <834jo1oeou.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 24 May 2023 19:51:45 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262312 Archived-At: >> @@ -898,6 +927,15 @@ vc-menu-map >> + (bindings--define-key map [vc-print-branch-log] >> + '(menu-item "Show Branch History" vc-print-branch-log >> + :help "Show the change log for branch root")) > > What is "branch root"? Probably better to drop the word "root" to e.g.: "List the change log for branch" Then docstring of 'vc-print-branch-log' could be changed too. >> + (bindings--define-key map [vc-switch-branch] >> + '(menu-item "Switch Branch" vc-switch-branch >> + :help "Switch to the branch")) > > "the" branch? Maybe "the selected branch". Then it may need an ellipsis: "Switch Branch..." > Also, AFAICT these commands are not described in the manual. If they > are important enough to be on the menu bar, I think we should mention > them in the manual as well, no? They are mentioned briefly in (info "(emacs) Creating Branches") (info "(emacs) Switching Branches") (info "(emacs) Editing VC Commands")