From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode Date: Fri, 15 Sep 2023 19:06:20 +0300 Organization: LINKOV.NET Message-ID: <86cyyjqwek.fsf@mail.linkov.net> References: <581f7e67-db12-ba3a-2354-de8061789861@matholka.se> <87360lnabu.fsf@gnus.org> <83a6uscwv2.fsf@gnu.org> <87eek4gl3p.fsf@mail.linkov.net> <86zg1puupr.fsf@mail.linkov.net> <868r986k8n.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15272"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 45029@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 18:08:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhBMb-0003op-QK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 18:08:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhBML-0003dF-HV; Fri, 15 Sep 2023 12:07:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhBMK-0003d5-L6 for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 12:07:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhBMK-0006K2-9F for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 12:07:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhBMQ-0001bI-F0 for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 12:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45029 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed confirmed Original-Received: via spool by 45029-submit@debbugs.gnu.org id=B45029.16947940286050 (code B ref 45029); Fri, 15 Sep 2023 16:08:02 +0000 Original-Received: (at 45029) by debbugs.gnu.org; 15 Sep 2023 16:07:08 +0000 Original-Received: from localhost ([127.0.0.1]:44530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhBLY-0001ZV-Gk for submit@debbugs.gnu.org; Fri, 15 Sep 2023 12:07:08 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:50867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhBLW-0001Yw-FL for 45029@debbugs.gnu.org; Fri, 15 Sep 2023 12:07:07 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 86CFE20004; Fri, 15 Sep 2023 16:06:52 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Fri, 15 Sep 2023 09:17:14 -0400") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270545 Archived-At: >>> The let-binding of `this-command` fixes the problem, doesn't it? >> But might other uses of a recursive edit break it again? > > What do you mean by `it`? Thanks for explanations. I thought it is specific to `delete-selection-mode` and `read-char-from-minibuffer`. But since a combination of `pre-command-hook` and a recursive command is a general problem, and OTOH `read-char-from-minibuffer` is already safeguarded by the let-binding of `this-command`, so probably `when (minibufferp)` could be removed from `read-char-from-minibuffer-insert-other`. > OTOH, the let-binding of `this-command` should fix the problem once and > for all uses of recursive edit *if* it's placed deep enough that it > affects all recursive edits. Frankly speaking, I'm afraid of making such change at great depths ;-)