From: Eli Zaretskii <eliz@gnu.org>
To: Martin Marshall <law@martinmarshall.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 68487@debbugs.gnu.org
Subject: bug#68487: [PATCH] Make jump commands usable for all skeletons
Date: Sun, 28 Jan 2024 07:52:48 +0200 [thread overview]
Message-ID: <86cytm6m33.fsf@gnu.org> (raw)
In-Reply-To: <87h6iy78hn.fsf@martinmarshall.com> (message from Martin Marshall on Sat, 27 Jan 2024 16:48:52 -0500)
> From: Martin Marshall <law@martinmarshall.com>
> Cc: 68487@debbugs.gnu.org
> Date: Sat, 27 Jan 2024 16:48:52 -0500
>
> Eli Zaretskii <eliz@gnu.org> writes:
> > OK. But after applying the patch on the master branch, I get this
> > while byte-compiling:
> >
> > In toplevel form:
> > expand.el:91:2: Error: Eager macro-expansion failure: (error "Eager macro-expansion skipped due to cycle:
> > => (load \"expand.el\") => (macroexpand-all (define-skeleton expand-c-for-skeleton )) => (macroexpand (define-skeleton )) => (load \"skeleton.el\") => (load \"expand.el\")")
> >
> > In toplevel form:
> > skeleton.el:34:11: Error: Eager macro-expansion failure: (error "Eager macro-expansion skipped due to cycle:
> > => (load \"expand.el\") => (macroexpand-all (define-skeleton expand-c-for-skeleton )) => (macroexpand (define-skeleton )) => (load \"skeleton.el\") => (load \"expand.el\")")
> > Makefile:335: recipe for target `skeleton.elc' failed
> > make[3]: *** [skeleton.elc] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > Makefile:335: recipe for target `expand.elc' failed
> >
> > Could you please DTRT to avoid these errors?
>
> Sorry, that was due to my incorrect assumption that byte-compiling with
> "C-c C-f" would be equivalent to a full recompile.
>
> I can fix it by deleting the sample skeleton (`expand-c-for-skeleton')
> from expand.el. But even though it's just a sample template, there
> might be people using it.
>
> Another option would be to join expand.el and skeleton.el into a single
> file, perhaps calling it "expand-skeleton.el".
>
> What do you think is best?
Neither alternative sounds attractive, TBH.
Stefan, what are our facilities to avoid mutual recursion like that?
Put the common stuff on a separate file, perhaps?
Thanks.
next prev parent reply other threads:[~2024-01-28 5:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 20:45 bug#68487: [PATCH] Make jump commands usable for all skeletons Martin Marshall
2024-01-27 9:13 ` Eli Zaretskii
2024-01-27 18:27 ` Martin Marshall
2024-01-27 18:51 ` Eli Zaretskii
2024-01-27 21:48 ` Martin Marshall
2024-01-28 5:52 ` Eli Zaretskii [this message]
2024-01-28 18:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28 19:24 ` Eli Zaretskii
2024-01-28 19:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-05 21:46 ` Martin Marshall
2024-02-06 2:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-06 22:11 ` Martin Marshall
2024-02-07 17:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-26 1:26 ` Martin Marshall
2024-03-03 4:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-14 7:50 ` Eli Zaretskii
2024-03-22 0:05 ` martin
2024-04-06 8:56 ` Eli Zaretskii
2024-04-18 8:58 ` Eli Zaretskii
2024-05-02 8:37 ` Eli Zaretskii
2024-05-18 8:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cytm6m33.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68487@debbugs.gnu.org \
--cc=law@martinmarshall.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).