From: Juri Linkov <juri@linkov.net>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: 69312@debbugs.gnu.org
Subject: bug#69312: 30.0.50; [WISHLIST] dicitionary buffer should retain search information
Date: Sat, 24 Feb 2024 19:39:02 +0200 [thread overview]
Message-ID: <86cyslep8p.fsf@mail.linkov.net> (raw)
In-Reply-To: <87frxjkxlt.fsf@gmail.com> (No Wayman's message of "Fri, 23 Feb 2024 10:29:34 -0500")
>> diff --git a/lisp/net/dictionary.el b/lisp/net/dictionary.el
>> index 1981b757017..ccce0b541df 100644
>> --- a/lisp/net/dictionary.el
>> +++ b/lisp/net/dictionary.el
>> @@ -787,7 +787,7 @@ dictionary-do-search
>> Optional argument NOMATCHING controls whether to suppress the display
>> of matching words."
>> - (message "Searching for %s in %s" word dictionary)
>> + (insert (format "Searching for %s in %s\n" word dictionary))
>> (dictionary-send-command (concat "define "
>> (dictionary-encode-charset dictionary "")
>> " \""
>
> Thanks, Juri. This takes care of dictionary-do-search, but
> dictionary-do-matching indirectly calls the function responsible for
> displaying the results and does not pass the query along. So a similar
> modification will not work there.
Sorry, I didn't notice there is another place:
diff --git a/lisp/net/dictionary.el b/lisp/net/dictionary.el
index 1981b757017..e2fc2d823fd 100644
--- a/lisp/net/dictionary.el
+++ b/lisp/net/dictionary.el
@@ -787,7 +787,7 @@ dictionary-do-search
Optional argument NOMATCHING controls whether to suppress the display
of matching words."
- (message "Searching for %s in %s" word dictionary)
+ (insert (format-message "Searching for %s in %s\n" word dictionary))
(dictionary-send-command (concat "define "
(dictionary-encode-charset dictionary "")
" \""
@@ -799,7 +799,7 @@ dictionary-do-search
(if (dictionary-check-reply reply 552)
(progn
(unless nomatching
- (insert "Word not found")
+ (insert (format-message "Word not found: %s\n" word))
(dictionary-do-matching
word
dictionary
@@ -1128,8 +1128,8 @@ dictionary-new-matching
(defun dictionary-do-matching (word dictionary strategy function)
"Search for WORD with STRATEGY in DICTIONARY and display them with FUNCTION."
- (message "Lookup matching words for %s in %s using %s"
- word dictionary strategy)
+ (insert (format-message "Lookup matching words for %s in %s using %s\n"
+ word dictionary strategy))
(dictionary-send-command
(concat "match " (dictionary-encode-charset dictionary "") " "
(dictionary-encode-charset strategy "") " \""
next prev parent reply other threads:[~2024-02-24 17:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 18:39 bug#69312: 30.0.50; [WISHLIST] dicitionary buffer should retain search information No Wayman
2024-02-23 7:12 ` Juri Linkov
2024-02-23 15:29 ` No Wayman
2024-02-24 17:39 ` Juri Linkov [this message]
2024-02-25 4:06 ` No Wayman
2024-02-25 7:19 ` Juri Linkov
2024-03-02 17:31 ` Juri Linkov
2024-03-03 1:46 ` No Wayman
2024-03-03 7:50 ` Juri Linkov
2024-03-03 16:59 ` Juri Linkov
2024-03-03 17:16 ` No Wayman
2024-03-03 17:49 ` Juri Linkov
2024-03-03 20:59 ` No Wayman
2024-03-05 16:43 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cyslep8p.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=69312@debbugs.gnu.org \
--cc=iarchivedmywholelife@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).