From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70208: [PATCH] Add command `list-keyboard-macros` Date: Sun, 07 Apr 2024 10:55:10 +0300 Message-ID: <86cyr11uap.fsf@gnu.org> References: <86msq85o7n.fsf@gnu.org> <8dd6fcfa-2fc0-4371-b5a9-1f451ff1e9a4@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7065"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70208@debbugs.gnu.org To: Okamsn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 07 09:56:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtNNs-0001bS-2b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Apr 2024 09:56:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtNNe-0007OS-VK; Sun, 07 Apr 2024 03:55:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtNNc-0007O5-1g for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 03:55:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtNNb-0006RU-Ob for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 03:55:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtNNi-0002tR-Be for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 03:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2024 07:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70208 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70208-submit@debbugs.gnu.org id=B70208.171247652910929 (code B ref 70208); Sun, 07 Apr 2024 07:56:02 +0000 Original-Received: (at 70208) by debbugs.gnu.org; 7 Apr 2024 07:55:29 +0000 Original-Received: from localhost ([127.0.0.1]:41492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtNN9-0002pt-ED for submit@debbugs.gnu.org; Sun, 07 Apr 2024 03:55:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtNN7-0002ow-5A for 70208@debbugs.gnu.org; Sun, 07 Apr 2024 03:55:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtNMv-0006L2-3M; Sun, 07 Apr 2024 03:55:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=D9ryaUqyw1/Wp7cd3Ttxp3XxipmqS0TdoXS0Xw/OgBk=; b=XZpDwk9JZOAT ApE7DQh6EP4qe3ovuWqO3R6FnBK63m//vqd13h8Z/y0T8NPryyNyPduubqscEbI+6pjtUk963knhO I4bbJG7zrVj/E6TzqWFjq9LIKDnrFJtBYnOQ6ZYKYu0Myg48zlK7UMHCKkQcdkMItGOQjYx/zcV8V dTBT+h541nJpUnJXUBM1PwhsPp5yQTA53wDbm+RJW3x9h1hxus0sQ4kQFaGIPyQgNmzT2WF2m7mJS dQ6q3597Lx4dSC1E/iGJ86Nw//a+09Eq1sl342ar2XZhLOs1hn3PBNKhH1tp/2FoUS3hDiVmH/wjx k4pPctxgQUgJiLvm/BWshw==; In-Reply-To: <8dd6fcfa-2fc0-4371-b5a9-1f451ff1e9a4@protonmail.com> (message from Okamsn on Sat, 06 Apr 2024 23:26:15 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282849 Archived-At: > Date: Sat, 06 Apr 2024 23:26:15 +0000 > From: Okamsn > Cc: 70208@debbugs.gnu.org > > +@node Kmacro Menu > +@section Listing Keyboard Macros "Listing and Editing", I guess? > +After a command is run, the Kmacro Menu resets to show the new values of ^^^^^^ "Resets" is not the best word here. I suggest to rephrase: After a command is run, the Kmacro Menu display changes to reflect the new values of ... > +the macro properties and the macro ring. The usual cursor motion > +commands can be used in this buffer. "You can use the usual cursor motion commands in this buffer." This avoids passive tense. > +@item D @r{(Kmacro Menu)} > +This command deletes macros, removing them from the ring > +(@code{kmacro-menu-do-delete}). For example, running this command on > +the macro at position zero will delete the current macro and then make > +the first macro in the macro ring (previously at position one) the new > +current macro, popping it from the ring. > + > + If the region is active, this command deletes the macros in the > +region. Otherwise, if there are marked macros, this command deletes the > +marked macros. If there is no region nor are there marked macros, this > +command deletes the macro on the current line. In all cases, the > +command prompts for confirmation before duplication. ^^^^^^^^^^^^^^^^^^ "before deletion", right? > ++++ > +*** New mode 'kmacro-menu-mode' and new command 'list-keyboard-macros'. > +The new command 'list-keyboard-macros' the macro version of commands ^ I think "is" is missing there. > +(defface kmacro-menu-mark '((t (:inherit font-lock-constant-face))) > + "Face used for the Keyboard Macro Menu marks." > + :group 'kmacro > + :version "30.0.50") The version should be "30.1", the next released version (here and elsewhere in the patch). We never tag options with development versions. > +(defun kmacro-menu-mark () > + "Mark macros in the region or, otherwise, on the current line. I'd remove the "otherwise" part, and explain that in the next lines: Mark macros in the region or on the current line. If there's an active region, mark macros in the region; otherwise mark the macro on the current line. > +(defun kmacro-menu-flag-for-deletion () > + "Flag macros in the region or, otherwise, on the current line. Likewise here and in all other similar commands (some of them already have the "if there's an active region" part). Thanks.