From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>, Spencer Baugh <sbaugh@janestreet.com>
Cc: 70822@debbugs.gnu.org
Subject: bug#70822: flymake mishandles GCC diagnostics in en_US.UTF-8 locale
Date: Wed, 08 May 2024 16:05:22 +0300 [thread overview]
Message-ID: <86cypwa1yl.fsf@gnu.org> (raw)
In-Reply-To: <bf6871f3-a35f-4622-83e0-541995372510@cs.ucla.edu> (message from Paul Eggert on Tue, 7 May 2024 10:06:59 -0700)
> Date: Tue, 7 May 2024 10:06:59 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
>
> In the en_US.UTF-8 locale on Fedora 40, (GCC) 14.0.1 20240411 (Red Hat
> 14.0.1-0) uses curved single quotes ‘like this’. This causes Emacs ‘make
> check’ to fail in the flymake tests.
>
> For example, in the C locale 'gcc
> test/lisp/progmodes/flymake-resources/some-problems.h' outputs this:
>
> test/lisp/progmodes/flymake-resources/some-problems.h:3:1: warning:
> data definition has no type or storage class
> 3 | strange;
> | ^~~~~~~
> test/lisp/progmodes/flymake-resources/some-problems.h:3:1: warning:
> type defaults to 'int' in declaration of 'strange' [-Wimplicit-int]
> test/lisp/progmodes/flymake-resources/some-problems.h:7:1: error:
> unknown type name 'sint'; did you mean 'int'?
> 7 | sint main();
> | ^~~~
> | int
>
> whereas in the en_US.UTF-8 locale the same command outputs this instead:
>
> test/lisp/progmodes/flymake-resources/some-problems.h:3:1: warning:
> data definition has no type or storage class
> 3 | strange;
> | ^~~~~~~
> test/lisp/progmodes/flymake-resources/some-problems.h:3:1: error:
> type defaults to ‘int’ in declaration of ‘strange’ [-Wimplicit-int]
> test/lisp/progmodes/flymake-resources/some-problems.h:7:1: error:
> unknown type name ‘sint’; did you mean ‘int’?
> 7 | sint main();
> | ^~~~
> | int
>
> and flymake mishandles the latter set of diagnostics.
AFAICT, flymake-tests.el injects LC_ALL=C into process-environment (in
flymake-tests--call-with-fixture called from
flymake-tests--with-flymake), so why doesn't that affect the locale
under which the test runs?
And could you perhaps show the error message reported by the failing
test(s) in that case?
next prev parent reply other threads:[~2024-05-08 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 17:06 bug#70822: flymake mishandles GCC diagnostics in en_US.UTF-8 locale Paul Eggert
2024-05-08 13:05 ` Eli Zaretskii [this message]
2024-05-08 17:10 ` Paul Eggert
2024-05-08 18:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cypwa1yl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70822@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).