From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Wed, 12 Jun 2024 12:41:33 +0300 Message-ID: <86cyom1os2.fsf@gnu.org> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33133"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71499@debbugs.gnu.org To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?Lindstr=C3=B6m?= , Stefan Kangas , Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 12 11:42:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHKUj-0008Ql-Lq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jun 2024 11:42:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHKUX-0007Q8-5P; Wed, 12 Jun 2024 05:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHKUV-0007Pl-CQ for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 05:42:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHKUV-0005OO-4l for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 05:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sHKUT-0007dB-JV for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 05:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2024 09:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71499-submit@debbugs.gnu.org id=B71499.171818530329306 (code B ref 71499); Wed, 12 Jun 2024 09:42:01 +0000 Original-Received: (at 71499) by debbugs.gnu.org; 12 Jun 2024 09:41:43 +0000 Original-Received: from localhost ([127.0.0.1]:37645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHKUA-0007cc-Ka for submit@debbugs.gnu.org; Wed, 12 Jun 2024 05:41:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHKU8-0007cP-JF for 71499@debbugs.gnu.org; Wed, 12 Jun 2024 05:41:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHKU3-0005MN-VS; Wed, 12 Jun 2024 05:41:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=JYUpWJgSNvLYQRdi1RAf9HNMZz0vAmkFUB6I9nRCCe0=; b=GFTbmfYKsuxvH0l/b5Y6 VecKdHEnMoq6czvxhUElu4fHP5RCgMPXurmDeyfRXzYXrO1+wAYNjRbTNVx33Lpg88WI37s3W7L4S PBIKdh9gcXLtkp1uMZDMEGPhsRTc0dX527gAW/r8+j+aW5+AUTPGUs2BByMIp3bTPov3EyghFsyn+ KkK9z5Ii1bSpM/FzG6DSePwbGRFcL50HvjjTgaJwwZlDkq9RiS5s5KT1VuBx9gbGhdBIW9IHRXJpb CWhGmtGxFvokDVD/2vATJd2Scsf6DRYnP6F4cPR4Wmo9nowe6fNF8gUCNAbKbFbNS83StrFZ5ILxv 6tZMAYNr//bDhA==; In-Reply-To: (message from =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?Lindstr=C3=B6m?= on Wed, 12 Jun 2024 11:04:18 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287147 Archived-At: > Date: Wed, 12 Jun 2024 11:04:18 +0200 > From: Björn Lindström > Cc: 71499@debbugs.gnu.org > > On Wed, Jun 12, 2024, at 09:46, Eli Zaretskii wrote: > >> Date: Tue, 11 Jun 2024 20:16:03 +0200 > >> From: Björn Lindström > >> > > This is an incompatible change of behavior on behalf of > > whitespace-cleanup, so I don't think we can accept it as in this patch > > (or the next one you sent). Se we'd need some new user option, by > > default off, to turn on this new feature. Or maybe a new action for > > whitespace-action? > > > > Thanks. > > Hello, > > I thought about that, but since whitespace-cleanup generally applies clean-up according to white-space style, I thought it was simply an oversight that it doesn't apply a fix when it is set to highlight missing end-of-file newline. > > Adding a separate way to configure this removes the simplicity of configuring your preferred whitespace-style as a single option. > > However, If you still disagree I can make another patch somehow maintains the old behaviour as the default, so just let me know. Let's see what others think, and take it from there. Stefan, Andrea: WDYT about this change?